Skip to content

tests: Move asyncpg under toxgen#4757

Merged
sentrivana merged 13 commits intomasterfrom
ivana/toxgen/asyncpg
Sep 4, 2025
Merged

tests: Move asyncpg under toxgen#4757
sentrivana merged 13 commits intomasterfrom
ivana/toxgen/asyncpg

Conversation

@sentrivana
Copy link
Copy Markdown
Contributor

@sentrivana sentrivana commented Sep 4, 2025 •
edited
Loading

  • remove hardcoded asyncpg config, let toxgen take care of generating it
  • isolate DB so that multiple asyncpg test suites for different envs can run at the same time without touching the same DB
  • update instructions on running the test suite locally

Ref #4506

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.77%. Comparing base (58a9827) to head (84328bd).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4757   +/-   ##
=======================================
  Coverage   84.76%   84.77%           
=======================================
  Files         158      158           
  Lines       16323    16323           
  Branches     2792     2792           
=======================================
+ Hits        13837    13838    +1     
+ Misses       1671     1670    -1     
  Partials      815      815

see 2 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review September 4, 2025 10:26
@sentrivana sentrivana requested a review from a team as a code owner September 4, 2025 10:26
@sentrivana sentrivana enabled auto-merge (squash) September 4, 2025 12:42
@sentrivana sentrivana disabled auto-merge September 4, 2025 12:47
@sentrivana sentrivana enabled auto-merge (squash) September 4, 2025 13:38
cursor[bot]
cursor Bot reviewed Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Tox Environment Mismatch in CI

The CI workflow attempts to run py${{ matrix.python-version }}-asyncpg-latest tests. However, the asyncpg-latest tox environment no longer exists after migrating to auto-generated toxgen configuration, which only creates specific versioned targets. This causes the CI job to fail.

.github/workflows/test-integrations-dbs.yml#L70-L79

sentry-python/.github/workflows/test-integrations-dbs.yml

Lines 70 to 79 in 84328bd

- name: Erase coverage
run: |
coverage erase
- name: Test asyncpg latest
run: |
set -x # print commands that are executed
./scripts/runtox.sh "py${{ matrix.python-version }}-asyncpg-latest"
- name: Test clickhouse_driver latest
run: |
set -x # print commands that are executed

.github/workflows/test-integrations-dbs.yml#L94-L97

sentry-python/.github/workflows/test-integrations-dbs.yml

Lines 94 to 97 in 84328bd

run: |
set -x # print commands that are executed
./scripts/runtox.sh "py${{ matrix.python-version }}-sqlalchemy-latest"
- name: Generate coverage XML (Python 3.6)

Fix in Cursor Fix in Web

@sentrivana sentrivana merged commit 9711b3b into master Sep 4, 2025
132 checks passed
@sentrivana sentrivana deleted the ivana/toxgen/asyncpg branch September 4, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sentrivana @alexander-alderman-webb