Iconv::IllegalSequence #181
Description
A coworker pushed a few commits, one of which added a new PDF file in a branch. He got this error:
remote: Sending mail...
remote: /var/lib/gems/1.8/gems/git-commit-notifier-0.11.11mg2/lib/git_commit_notifier/diff_to_html.rb:541:in `iconv': "\223\214\213\236 ReportLab G"... (Iconv::IllegalSequence)
remote: from /var/lib/gems/1.8/gems/git-commit-notifier-0.11.11mg2/lib/git_commit_notifier/diff_to_html.rb:541:in `diff_for_commit'
remote: from /var/lib/gems/1.8/gems/git-commit-notifier-0.11.11mg2/lib/git_commit_notifier/diff_to_html.rb:713:in `diff_for_branch'
remote: from /var/lib/gems/1.8/gems/git-commit-notifier-0.11.11mg2/lib/git_commit_notifier/diff_to_html.rb:712:in `each'
remote: from /var/lib/gems/1.8/gems/git-commit-notifier-0.11.11mg2/lib/git_commit_notifier/diff_to_html.rb:712:in `diff_for_branch'
remote: from /var/lib/gems/1.8/gems/git-commit-notifier-0.11.11mg2/lib/git_commit_notifier/diff_to_html.rb:761:in `diff_between_revisions'
remote: from /var/lib/gems/1.8/gems/git-commit-notifier-0.11.11mg2/lib/git_commit_notifier/commit_hook.rb:241:in `run'
remote: from /var/lib/gems/1.8/gems/git-commit-notifier-0.11.11mg2/lib/git_commit_notifier/executor.rb:29:in `run!'
remote: from /var/lib/gems/1.8/gems/git-commit-notifier-0.11.11mg2/lib/git_commit_notifier/executor.rb:27:in `each_line'
remote: from /var/lib/gems/1.8/gems/git-commit-notifier-0.11.11mg2/lib/git_commit_notifier/executor.rb:27:in `run!'
remote: from /var/lib/gems/1.8/gems/git-commit-notifier-0.11.11mg2/bin/git-commit-notifier:15
remote: from /usr/local/bin/git-commit-notifier:19:in `load'
remote: from /usr/local/bin/git-commit-notifier:19
I can reproduce it with today's master.
In case it matters, I have a .gitattributes file in that branch that contains *.pdf binary.
Ideally, git-commit-notifier wouldn't try to diff PDFs at all, as per .gitattributes, but I'll settle for not crashing and omitting emails of this and all other commits in that particular push. ;-)