Closed
Conversation
Contributor
Author
|
We will likely want to update all the code after we merge the PRs that we plan on releasing this week. Other PRs can fix any potential merge conflicts. |
Contributor
|
@chingor13 which files did you change manually for this PR? |
Contributor
Author
|
@sduskis Only the code in the first 3 commits: master...e636610 The final commit was from running the fixer command: |
Contributor
Author
|
Looks like I need to add an exception for the generated code in google-cloud-clients. Otherwise, autosynth PRs will fail the linter checks. |
| import com.google.bigtable.v2.MutateRowRequest; | ||
| import com.google.bigtable.v2.MutateRowResponse; | ||
| import com.google.bigtable.v2.MutateRowsRequest; | ||
| import com.google.bigtable.v2.MutateRowsRequest.Entry; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Adding the ability to reformat the generated java code in: googleapis/synthtool#145. Will open a new PR with those changes. |
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
* feat(bigquery): Add custom ExceptionHandler to BigQueryOptions * add default project id to tests * Add dummy project id to tests * Remove defaultInstance() from test * add option to specify retry algo instead of just abortOn/retryOn * fix formatting * remove custom exception handler from bq options
lqiu96
pushed a commit
that referenced
this pull request
Mar 20, 2026
* feat(bigquery): Add custom ExceptionHandler to BigQueryOptions * add default project id to tests * Add dummy project id to tests * Remove defaultInstance() from test * add option to specify retry algo instead of just abortOn/retryOn * fix formatting * remove custom exception handler from bq options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Kokoro test job "Kokoro - Test: Code Format" that runs all code outside of google-api-grpc through the google-java-format code linter via the
com.coveo:fmt-maven-plugin.We also fix all the code style issues.