balancer/least_request : Fix panic while handling resolver errors#8333
Merged
arjan-bal merged 2 commits intogrpc:masterfrom May 19, 2025
Merged
balancer/least_request : Fix panic while handling resolver errors#8333arjan-bal merged 2 commits intogrpc:masterfrom
arjan-bal merged 2 commits intogrpc:masterfrom
Conversation
There was a leftover embedded balancer in least request that was never set in the code when it got refactored to pick first as leaf. As a result, method calls forwarded to the embedded balancer would panic. Remove the embedded balance and properly forward the missing methods. Fixes grpc#8332.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8333 +/- ##
==========================================
- Coverage 82.41% 82.32% -0.10%
==========================================
Files 419 419
Lines 42025 42034 +9
==========================================
- Hits 34637 34604 -33
- Misses 5944 5974 +30
- Partials 1444 1456 +12
🚀 New features to boost your workflow:
|
Collaborator
Author
|
Looking at the coverage report, I'm unclear on why the test doesn't cover the added implementation... Will look into it. Good to review otherwise. |
arjan-bal
reviewed
May 16, 2025
arjan-bal
approved these changes
May 19, 2025
arjan-bal
pushed a commit
to arjan-bal/grpc-go
that referenced
this pull request
May 19, 2025
arjan-bal
pushed a commit
to arjan-bal/grpc-go
that referenced
this pull request
May 19, 2025
arjan-bal
pushed a commit
to arjan-bal/grpc-go
that referenced
this pull request
May 19, 2025
This was referenced May 19, 2025
arjan-bal
added a commit
that referenced
this pull request
May 19, 2025
arjan-bal
added a commit
that referenced
this pull request
May 19, 2025
arjan-bal
added a commit
that referenced
this pull request
May 19, 2025
hugehoo
pushed a commit
to hugehoo/grpc-go
that referenced
this pull request
May 20, 2025
hugehoo
pushed a commit
to hugehoo/grpc-go
that referenced
this pull request
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a leftover embedded balancer in least request that was never set in the code when it got refactored to pick first as leaf. As a result, method calls forwarded to the embedded balancer would panic.
Remove the embedded balance and properly forward the missing methods.
Fixes #8332
RELEASE NOTES: