Skip to content

Cherrypick #8702 to v1.77.x#8709

Merged
easwars merged 1 commit intogrpc:v1.77.xfrom
easwars:v1.77.x
Nov 17, 2025
Merged

Cherrypick #8702 to v1.77.x#8709
easwars merged 1 commit intogrpc:v1.77.xfrom
easwars:v1.77.x

Conversation

@easwars
Copy link
Copy Markdown
Contributor

@easwars easwars commented Nov 14, 2025 •
edited
Loading

#8548 changed the grpc status code returned on missing grpc-status header to Internal. This PR changes it back to Unknown as that is the expected behavior.

See grpc/grpc@master/doc/statuscodes.md for more details. Here Unknown is defined as follows:

Unknown error. For example, this error may be returned when a Status value received 
from another address space belongs to an error space that is not known in this 
address space. Also errors raised by APIs that do not return enough error information
may be converted to this error.

RELEASE NOTES:

  • transport/client : Return status code Unknown on missing grpc-status.

@mbissa @easwars
transport/client: Return Unknown on missing or unparsable grpc-stat…
b3e21d8 
…us (grpc#8702)

See https://github.com/grpc/grpc/blob/master/doc/statuscodes.md for more
details.

RELEASE NOTES:
* transport/client : Return Unknown on missing or unparsable
grpc-status.
@easwars easwars requested a review from dfawley November 14, 2025 21:28
@easwars easwars added Type: Bug Area: Client Includes Channel/Subchannel/Streams, Connectivity States, RPC Retries, Dial/Call Options and more. labels Nov 14, 2025
@easwars easwars added this to the 1.78 Release milestone Nov 14, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.21%. Comparing base (cadae08) to head (b3e21d8).
⚠️ Report is 1 commits behind head on v1.77.x.

Additional details and impacted files 
@@             Coverage Diff             @@
##           v1.77.x    #8709      +/-   ##
===========================================
- Coverage    83.28%   83.21%   -0.07%     
===========================================
  Files          418      418              
  Lines        32347    32347              
===========================================
- Hits         26941    26919      -22     
- Misses        4029     4040      +11     
- Partials      1377     1388      +11
Files with missing lines Coverage Δ
internal/transport/http2_client.go 92.41% <100.00%> (+0.48%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dfawley dfawley assigned easwars and unassigned dfawley Nov 14, 2025
@easwars easwars merged commit ea7b66e into grpc:v1.77.x Nov 17, 2025
14 of 18 checks passed
@easwars easwars deleted the v1.77.x branch November 17, 2025 18:35
@arjan-bal arjan-bal modified the milestones: 1.78 Release, 1.77 Release Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@easwars easwars

Labels

Area: Client Includes Channel/Subchannel/Streams, Connectivity States, RPC Retries, Dial/Call Options and more. Type: Bug

Projects

None yet

Milestone

1.77 Release

Development

Successfully merging this pull request may close these issues.

4 participants

@easwars @dfawley @arjan-bal @mbissa