src/datamodel_code_generator/model/pydantic_v2/dataclass.py (2)

120-127: Consider centralizing version-based config selection to avoid drift.

This method duplicates the selector in src/datamodel_code_generator/model/pydantic_v2/base_model.py (same version branching). A shared helper/mixin would reduce future divergence risk.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/datamodel_code_generator/model/pydantic_v2/dataclass.py` around lines 120
- 127, The _get_config_attributes method duplicates version-branching logic
present in base_model.py; extract the version selector into a single shared
helper (e.g., a function or mixin) that accepts the extra_template_data (or
target_version) and returns the appropriate config constant, then replace the
branching in dataclass._get_config_attributes and the analogous method in
base_model to call that shared helper; reference the symbols
TargetPydanticVersion, _CONFIG_ATTRIBUTES_V2_11, _CONFIG_ATTRIBUTES_V2, and
_get_config_attributes when locating places to replace.

---

38-48: Make key precedence explicit for duplicate destination mappings.

Both allow_population_by_field_name and populate_by_name target the same config key. Today precedence is implicit via list order. Consider documenting the intended winner (or enforcing it in code) to avoid accidental behavior changes during future reordering.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/datamodel_code_generator/model/pydantic_v2/dataclass.py` around lines 38
- 48, The lists _CONFIG_ATTRIBUTES_V2 and _CONFIG_ATTRIBUTES_V2_11 contain
duplicate destination mappings for allow_population_by_field_name and
populate_by_name which makes precedence implicit; update the dataclass mapping
so the intended winner is explicit—either remove the duplicate entry for the
losing key from those lists, add an explicit priority flag to the
ConfigAttribute type and set it for allow_population_by_field_name vs
populate_by_name, or update the resolution logic that consumes these lists to
prefer a named winner—ensure you modify ConfigAttribute and the consumer code
together (references: _CONFIG_ATTRIBUTES_V2, _CONFIG_ATTRIBUTES_V2_11,
ConfigAttribute, keys allow_population_by_field_name and populate_by_name) and
add a short comment documenting the chosen precedence.

tests/main/jsonschema/test_main_jsonschema.py (1)

1847-1861: Add coverage for the --target-pydantic-version 2.11 path.

This test covers the default v2 dataclass path well, but the PR also introduces version-specific config mapping. Please add a companion test with target_pydantic_version="2.11" so the new branch is regression-protected.

Proposed test addition

+def test_main_generate_pydantic_v2_dataclass_allow_population_by_field_name_target_2_11(tmp_path: Path) -> None:
+    """Test pydantic_v2.dataclass with allow_population_by_field_name for target pydantic 2.11."""
+    output_file: Path = tmp_path / "output.py"
+    input_ = (JSON_SCHEMA_DATA_PATH / "simple_string.json").relative_to(Path.cwd())
+    assert not input_.is_absolute()
+    generate(
+        input_=input_,
+        input_file_type=InputFileType.JsonSchema,
+        output=output_file,
+        output_model_type=DataModelType.PydanticV2Dataclass,
+        allow_population_by_field_name=True,
+        target_pydantic_version="2.11",
+    )
+
+    assert_file_content(output_file, "pydantic_v2_dataclass_populate_by_name_target_2_11.py")

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/main/jsonschema/test_main_jsonschema.py` around lines 1847 - 1861, Add
a new test mirroring
test_main_generate_pydantic_v2_dataclass_allow_population_by_field_name named
something like
test_main_generate_pydantic_v2_dataclass_allow_population_by_field_name_target_2_11
that calls generate with the same parameters but adds
target_pydantic_version="2.11" (keep input_ and output_file setup identical) and
asserts the generated output matches the expected fixture (use a new fixture
file name such as pydantic_v2_dataclass_populate_by_name_p2_11.py or reuse
appropriate expected content). This will exercise the version-specific config
mapping path in generate and protect the 2.11 branch.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro