Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
=======================================
Coverage 99.74% 99.75%
=======================================
Files 1 1
Lines 398 400 +2
Branches 158 161 +3
=======================================
+ Hits 397 399 +2
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blakeembrey
commented
Apr 1, 2026
| const stack = (error as Error).stack | ||
| ?.split("\n") | ||
| .slice(0, 5) | ||
| .slice(0, 6) |
Member
Author
There was a problem hiding this comment.
Introducing process for handling the recursive array introduces an extra stack. In a new major we should drop the ability to have infinite recursion and we won't need this function anymore. But for now it avoids a new array getting created.
704b0de to
e4d0516
Compare
e4d0516 to
d679ff6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing a couple of code paths to remove array allocations entirely without any changes to code behavior.