Minor refactor to expandPatterns#15317
Merged
fisker merged 2 commits intoprettier:mainfrom Aug 28, 2023
Merged
Conversation
Member
Author
|
... This happened fixes #15001 somehow. That's something I didn't expected. |
sosukesuzuki
approved these changes
Aug 28, 2023
Member
Author
|
I also tested that using array doesn't effect speed. Test scriptimport fg from 'fast-glob'
for (const patterns of [
'node_modules/**/{*.js,*.json,*.md}',
['node_modules/**/*.js','node_modules/**/*.json','node_modules/**/*.md'],
]) {
fg.sync(patterns) // warm up
const label = JSON.stringify(patterns)
console.time(label);
const result = fg.sync(patterns, {dot: true})
console.log(`${result.length} files found`)
console.timeEnd(label)
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found that
fast-globcan't glob any file with**/{*.js}(single extension), the original code works because we always have manyextensionsandfilenamesinlanguages.I guess better pass an array to
fast-globinstead to be safer.Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨