Derive settings_path from --filename#1992
Conversation
Remove the or-clause because `os.path.abspath(".")` equals
`os.getcwd()`.
Fixes PyCQA#1989 `--filename` is a shortcut setting used only in the stdin case to set the `settings_path`. Generally, `--settings-path=<file_path>` == `--filename=<filename>` should hold. This functionality was removed in 0973421 (Reuse config when items passed in through stdin as used when items passed in explicitly).
| if "settings_path" not in arguments: | ||
| arguments["settings_path"] = ( | ||
| os.path.abspath(file_names[0] if file_names else ".") or os.getcwd() | ||
| arguments.get("filename", None) or os.getcwd() |
There was a problem hiding this comment.
| arguments.get("filename", None) or os.getcwd() | |
| os.path.abspath(arguments.get("filename", None) or os.getcwd()) |
Should --filename argument be wrapped with abspath as well?
There was a problem hiding this comment.
I think that's confusing because then it depends on the working dir again. The working dir is not as easy to get right for editors; it might be the topmost open folder, or the first folder with .git in it. And then we need to construct a relative filename of course to set it as the argument.
|
I have checked out this branch and tried it in VSCode, and this does indeed solve all issues I had with #1989 and microsoft/vscode-isort#53. Would it be possible to merge this soon? I unfortunately have no input regarding the |
|
@kaste This bug affects our (VS Code extension for isort) ability to provide import sorting on unsaved files. If this can be merged soon it would be greatly helpful to improve the experience. |
|
@karthiknadig I just did the PR here to fix the bug. I have no merge rights whatsoever. 🤷 |
|
@timothycrosley would it be possible for you to take a look at this? |
Fixes #1989
--filenameis a shortcut setting used only in the stdin case to setthe
settings_path.Generally,
--settings-path=<file_path>==--filename=<filename>should hold.
This functionality was removed in 0973421 (Reuse config when items
passed in through stdin as used when items passed in explicitly).