Update line_length and single_line_exclusions in google profile by jagapiou · Pull Request #2149 · PyCQA/isort

jagapiou · 2023-06-29T18:56:23Z

Updated the google profile to match the style guide

staticdev · 2023-06-30T05:56:59Z

@jagapiou do you maybe have a link of those changes?

jagapiou · 2023-07-05T12:50:13Z

Line-length exemption for imports: https://google.github.io/styleguide/pyguide.html#32-line-length
Allowing multiple imports from collections.abc: https://google.github.io/styleguide/pyguide.html#313-imports-formatting

jagapiou · 2023-07-19T01:03:01Z

@staticdev just a ping on this in case it slipped your notifications. Anything else you need me to do?

staticdev · 2023-09-29T17:21:13Z

Sorry for missing this @jagapiou . I see all checks are failing, we cannot merge like this.

jagapiou · 2023-09-29T18:19:53Z

No probs :-) I think those failures weren't my change, but the main it was based on. I've rebased, not sure how to run the checks.

DanielNoord

Part of this is also included in #2328

staticdev · 2025-01-15T21:00:33Z

@jagapiou sorry for super long time but let's merge. Thanks!

jagapiou · 2025-01-16T09:41:59Z

No probs, thank you!

This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [isort](https://github.com/PyCQA/isort) ([changelog](https://github.com/PyCQA/isort/releases)) | dev | major | `^5.13.2` → `^7.0.0` | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/PyCQA/isort/badge)](https://securityscorecards.dev/viewer/?uri=github.com/PyCQA/isort) | --- ### Release Notes <details> <summary>PyCQA/isort (isort)</summary> ### [`v7.0.0`](https://github.com/PyCQA/isort/releases/tag/7.0.0) [Compare Source](PyCQA/isort@6.1.0...7.0.0) #### Changes #### 💥 Breaking Changes - Drop support for Python 3.9 ([#2430](PyCQA/isort#2430)) [@DanielNoord](https://github.com/DanielNoord) #### 🚀 Features - Show absolute paths in skipped file messages ([#2416](PyCQA/isort#2416)) [@pranlawate](https://github.com/pranlawate) #### 🪲 Fixes - Some fixes for Python 3.14 ([#2433](PyCQA/isort#2433)) [@DanielNoord](https://github.com/DanielNoord) - Test on `3.14` and fix any bugs ([#2425](PyCQA/isort#2425)) [@DanielNoord](https://github.com/DanielNoord) - Update CHANGELOG.md + Fix Formatting and Grammar ([#2419](PyCQA/isort#2419)) [@lukbrew25](https://github.com/lukbrew25) - Fix output of hanging indent for long lines with noqa ([#2407](PyCQA/isort#2407)) [@matan1008](https://github.com/matan1008) #### :construction\_worker: Continuous Integration - Format with `ruff` instead of `black` ([#2432](PyCQA/isort#2432)) [@DanielNoord](https://github.com/DanielNoord) - Target 3.10 for `ruff` ([#2431](PyCQA/isort#2431)) [@DanielNoord](https://github.com/DanielNoord) - Update development dependencies to latest version ([#2426](PyCQA/isort#2426)) [@DanielNoord](https://github.com/DanielNoord) - docs: update pre-commit examples to version 6.1.0 ([#2413](PyCQA/isort#2413)) [@pranlawate](https://github.com/pranlawate) - Small cleanup for developer environment ([#2418](PyCQA/isort#2418)) [@DanielNoord](https://github.com/DanielNoord) #### 📦 Dependencies - Bump actions/setup-python from 5 to 6 in the github-actions group ([#2411](PyCQA/isort#2411)) @[dependabot\[bot\]](https://github.com/apps/dependabot) ### [`v6.1.0`](https://github.com/PyCQA/isort/blob/HEAD/CHANGELOG.md#610-October-1-2025) [Compare Source](PyCQA/isort@6.0.1...6.1.0) - Add python 3.14 classifier and badge ([#2409](PyCQA/isort#2409)) [@staticdev](https://github.com/staticdev) - Drop use of non-standard pkg\_resources API ([#2405](PyCQA/isort#2405)) [@dvarrazzo](https://github.com/dvarrazzo) ### [`v6.0.1`](https://github.com/PyCQA/isort/blob/HEAD/CHANGELOG.md#601-Febuary-26-2025) [Compare Source](PyCQA/isort@6.0.0...6.0.1) - Add OSError handling in find\_imports\_in\_file ([#2331](PyCQA/isort#2331)) [@kobarity](https://github.com/kobarity) ### [`v6.0.0`](https://github.com/PyCQA/isort/blob/HEAD/CHANGELOG.md#600-January-27-2025) [Compare Source](PyCQA/isort@5.13.2...6.0.0) - Remove support for Python 3.8 ([#2327](PyCQA/isort#2327)) [@DanielNoord](https://github.com/DanielNoord) - Python 3.13 support ([#2306](PyCQA/isort#2306)) [@mayty](https://github.com/mayty) - Speed up exists\_case\_sensitive calls ([#2264](PyCQA/isort#2264)) [@correctmost](https://github.com/correctmost) - Ensure that split\_on\_trailing\_comma works with as imports ([#2340](PyCQA/isort#2340)) [@DanielNoord](https://github.com/DanielNoord) - Black profile: enable magic comma ([#2236](PyCQA/isort#2236)) [@MrMino](https://github.com/MrMino) - Update line\_length and single\_line\_exclusions in google profile ([#2149](PyCQA/isort#2149)) [@jagapiou](https://github.com/jagapiou) - Allow --diff to be used with --jobs ([#2302](PyCQA/isort#2302)) [@mnakama](https://github.com/mnakama) - Fix wemake profile to have correct character limit ([#2241](PyCQA/isort#2241)) [@sobolevn](https://github.com/sobolevn) - Fix sort\_reexports code mangling ([#2283](PyCQA/isort#2283)) [@Helveg](https://github.com/Helveg) - Fix correct group by package tokenization ([#2136](PyCQA/isort#2136)) [@glasnt](https://github.com/glasnt) </details> --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  See merge request swiss-armed-forces/cyber-command/cea/loom!284 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: shrewd-laidback palace <shrewd-laidback-palace-736-c41-2c1-e464fc974@swiss-armed-forces-open-source.ch>

chore(deps): update isort (major) This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [isort](https://github.com/PyCQA/isort) ([changelog](https://github.com/PyCQA/isort/releases)) | dev | major | `^5.13.2` → `^7.0.0` | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/PyCQA/isort/badge)](https://securityscorecards.dev/viewer/?uri=github.com/PyCQA/isort) | --- ### Release Notes <details> <summary>PyCQA/isort (isort)</summary> ### [`v7.0.0`](https://github.com/PyCQA/isort/releases/tag/7.0.0) [Compare Source](PyCQA/isort@6.1.0...7.0.0) #### Changes #### 💥 Breaking Changes - Drop support for Python 3.9 ([#2430](PyCQA/isort#2430)) [@DanielNoord](https://github.com/DanielNoord) #### 🚀 Features - Show absolute paths in skipped file messages ([#2416](PyCQA/isort#2416)) [@pranlawate](https://github.com/pranlawate) #### 🪲 Fixes - Some fixes for Python 3.14 ([#2433](PyCQA/isort#2433)) [@DanielNoord](https://github.com/DanielNoord) - Test on `3.14` and fix any bugs ([#2425](PyCQA/isort#2425)) [@DanielNoord](https://github.com/DanielNoord) - Update CHANGELOG.md + Fix Formatting and Grammar ([#2419](PyCQA/isort#2419)) [@lukbrew25](https://github.com/lukbrew25) - Fix output of hanging indent for long lines with noqa ([#2407](PyCQA/isort#2407)) [@matan1008](https://github.com/matan1008) #### :construction\_worker: Continuous Integration - Format with `ruff` instead of `black` ([#2432](PyCQA/isort#2432)) [@DanielNoord](https://github.com/DanielNoord) - Target 3.10 for `ruff` ([#2431](PyCQA/isort#2431)) [@DanielNoord](https://github.com/DanielNoord) - Update development dependencies to latest version ([#2426](PyCQA/isort#2426)) [@DanielNoord](https://github.com/DanielNoord) - docs: update pre-commit examples to version 6.1.0 ([#2413](PyCQA/isort#2413)) [@pranlawate](https://github.com/pranlawate) - Small cleanup for developer environment ([#2418](PyCQA/isort#2418)) [@DanielNoord](https://github.com/DanielNoord) #### 📦 Dependencies - Bump actions/setup-python from 5 to 6 in the github-actions group ([#2411](PyCQA/isort#2411)) @[dependabot\[bot\]](https://github.com/apps/dependabot) ### [`v6.1.0`](https://github.com/PyCQA/isort/blob/HEAD/CHANGELOG.md#610-October-1-2025) [Compare Source](PyCQA/isort@6.0.1...6.1.0) - Add python 3.14 classifier and badge ([#2409](PyCQA/isort#2409)) [@staticdev](https://github.com/staticdev) - Drop use of non-standard pkg\_resources API ([#2405](PyCQA/isort#2405)) [@dvarrazzo](https://github.com/dvarrazzo) ### [`v6.0.1`](https://github.com/PyCQA/isort/blob/HEAD/CHANGELOG.md#601-Febuary-26-2025) [Compare Source](PyCQA/isort@6.0.0...6.0.1) - Add OSError handling in find\_imports\_in\_file ([#2331](PyCQA/isort#2331)) [@kobarity](https://github.com/kobarity) ### [`v6.0.0`](https://github.com/PyCQA/isort/blob/HEAD/CHANGELOG.md#600-January-27-2025) [Compare Source](PyCQA/isort@5.13.2...6.0.0) - Remove support for Python 3.8 ([#2327](PyCQA/isort#2327)) [@DanielNoord](https://github.com/DanielNoord) - Python 3.13 support ([#2306](PyCQA/isort#2306)) [@mayty](https://github.com/mayty) - Speed up exists\_case\_sensitive calls ([#2264](PyCQA/isort#2264)) [@correctmost](https://github.com/correctmost) - Ensure that split\_on\_trailing\_comma works with as imports ([#2340](PyCQA/isort#2340)) [@DanielNoord](https://github.com/DanielNoord) - Black profile: enable magic comma ([#2236](PyCQA/isort#2236)) [@MrMino](https://github.com/MrMino) - Update line\_length and single\_line\_exclusions in google profile ([#2149](PyCQA/isort#2149)) [@jagapiou](https://github.com/jagapiou) - Allow --diff to be used with --jobs ([#2302](PyCQA/isort#2302)) [@mnakama](https://github.com/mnakama) - Fix wemake profile to have correct character limit ([#2241](PyCQA/isort#2241)) [@sobolevn](https://github.com/sobolevn) - Fix sort\_reexports code mangling ([#2283](PyCQA/isort#2283)) [@Helveg](https://github.com/Helveg) - Fix correct group by package tokenization ([#2136](PyCQA/isort#2136)) [@glasnt](https://github.com/glasnt) </details> --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  See merge request swiss-armed-forces/cyber-command/cea/loom!284 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: open-source Pipeline <group_90701827_bot_ed04ae348bc5f40af9966fb8b6867e99@noreply.gitlab.com>

jagapiou force-pushed the google branch from b18164e to e65f945 Compare June 29, 2023 19:05

dseomn reviewed Sep 28, 2023

View reviewed changes

Comment thread isort/profiles.py Outdated

jagapiou requested a review from dseomn September 29, 2023 09:01

jagapiou changed the title ~~Update google profile~~ Update single_line_exclusions in google profile Sep 29, 2023

jagapiou force-pushed the google branch from 6744aa1 to ea2f8aa Compare September 29, 2023 09:18

jagapiou changed the title ~~Update single_line_exclusions in google profile~~ Update line_length and single_line_exclusions in google profile Sep 29, 2023

dseomn approved these changes Sep 29, 2023

View reviewed changes

jagapiou force-pushed the google branch from 966533c to ea2f8aa Compare September 29, 2023 18:14

Update line_length and single_line_exclusions for google profile

fab2404

jagapiou force-pushed the google branch from ea2f8aa to fab2404 Compare September 29, 2023 18:18

DanielNoord approved these changes Jan 14, 2025

View reviewed changes

staticdev approved these changes Jan 15, 2025

View reviewed changes

staticdev merged commit 0bd2403 into PyCQA:main Jan 15, 2025

jagapiou deleted the google branch January 16, 2025 09:42

This was referenced Jan 16, 2025

Allow single-line imports from collections.abc in Google profile #2328

Closed

Fix google style test #2336

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update line_length and single_line_exclusions in google profile#2149

Update line_length and single_line_exclusions in google profile#2149
staticdev merged 1 commit intoPyCQA:mainfrom
jagapiou:google

jagapiou commented Jun 29, 2023 •

edited

Loading

Uh oh!

staticdev commented Jun 30, 2023

Uh oh!

jagapiou commented Jul 5, 2023 •

edited

Loading

Uh oh!

jagapiou commented Jul 19, 2023 •

edited

Loading

Uh oh!

Uh oh!

staticdev commented Sep 29, 2023

Uh oh!

jagapiou commented Sep 29, 2023 •

edited

Loading

Uh oh!

DanielNoord left a comment

Uh oh!

staticdev commented Jan 15, 2025

Uh oh!

jagapiou commented Jan 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jagapiou commented Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

staticdev commented Jun 30, 2023

Uh oh!

jagapiou commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jagapiou commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

staticdev commented Sep 29, 2023

Uh oh!

jagapiou commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

staticdev commented Jan 15, 2025

Uh oh!

jagapiou commented Jan 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jagapiou commented Jun 29, 2023 •

edited

Loading

jagapiou commented Jul 5, 2023 •

edited

Loading

jagapiou commented Jul 19, 2023 •

edited

Loading

jagapiou commented Sep 29, 2023 •

edited

Loading