feat(biome): new package for a shared config#1004
Conversation
There was a problem hiding this comment.
I extrapolated the bulk of this from the config I ended up with over in Gitto.
| { | ||
| "$schema": "https://biomejs.dev/schemas/2.1.1/schema.json", | ||
| "formatter": { | ||
| "enabled": false, |
There was a problem hiding this comment.
Leaving this off by default since we still want to use Prettier in most places.
kanadgupta
left a comment
There was a problem hiding this comment.
i only just thought of this so apologies for suggesting this well after you implemented this but... what if we did the following:
- created a package called
@readme/standards - exposed an
exportsentry calledbiome(i.e.,@readme/standards/biome) that pointed to our biome config (per these docs) - exposed a
prettierentry (i.e.,@readme/standards/prettier) with our prettier config
the reason being i can't see us ditching prettier anytime soon1 and that way we can drop @readme/eslint-config while still having access to our prettier config
Footnotes
-
i'd take this with a grain of salt but some not-so-flattering chatter about biome popped up on my feed this weekend ↩
Co-authored-by: Kanad Gupta <[email protected]>
Co-authored-by: Kanad Gupta <[email protected]>
| "lint": "biome check", | ||
| "lint:fix": "biome check --write ." | ||
| }, | ||
| "optionalDependencies": { |
There was a problem hiding this comment.
Moved Biome and Prettier from peer deps to optional so they are only installed when needed.
kanadgupta
left a comment
There was a problem hiding this comment.
a few issues below but otherwise LGTM!
Co-authored-by: Kanad Gupta <[email protected]>
Co-authored-by: Kanad Gupta <[email protected]>
Co-authored-by: Kanad Gupta <[email protected]>
Co-authored-by: Kanad Gupta <[email protected]>
🧰 Changes
Since we're very slowly beginning to adopt Biome within our org we should have a common configuration.