Skip to content

Keyword arguments for PLAYWRIGHT_PROCESS_REQUEST_HEADERS, pass additional Request fields#303

Merged
elacuesta merged 7 commits intomainfrom
process-request-headers-keyword-arguments
Jul 18, 2024
Merged

Keyword arguments for PLAYWRIGHT_PROCESS_REQUEST_HEADERS, pass additional Request fields#303
elacuesta merged 7 commits intomainfrom
process-request-headers-keyword-arguments

Conversation

@elacuesta
Copy link
Copy Markdown
Member

@elacuesta elacuesta commented Jul 16, 2024

Deprecate passing arguments positionally to the function defined in PLAYWRIGHT_PROCESS_REQUEST_HEADERS, pass them as keyword instead. Pass additional data about the Scrapy request, not just the headers.

Tasks:

  • implementation
  • docs
  • tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5b8cfd7) to head (4098004).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #303   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          598       603    +5     
=========================================
+ Hits           598       603    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elacuesta elacuesta added this to the 0.0.40 milestone Jul 16, 2024
@elacuesta elacuesta marked this pull request as ready for review July 16, 2024 16:52
@elacuesta elacuesta changed the title Keyword arguments for PLAYWRIGHT_PROCESS_REQUEST_HEADERS Keyword arguments for PLAYWRIGHT_PROCESS_REQUEST_HEADERS, additional Request fields Jul 18, 2024
@elacuesta elacuesta changed the title Keyword arguments for PLAYWRIGHT_PROCESS_REQUEST_HEADERS, additional Request fields Keyword arguments for PLAYWRIGHT_PROCESS_REQUEST_HEADERS, pass additional Request fields Jul 18, 2024
@elacuesta elacuesta merged commit 84ba393 into main Jul 18, 2024
@elacuesta elacuesta deleted the process-request-headers-keyword-arguments branch July 18, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant