no-unused-properties: Fix for JSX member access (#2890)

sindresorhus · web-flow · commit 0ff698b337d0 · 2026-02-14T02:55:51.000+07:00
diff --git a/rules/no-unused-properties.js b/rules/no-unused-properties.js
@@ -25,28 +25,19 @@ const specialProtoPropertyKey = {
 	name: '__proto__',
 };
 
-const propertyKeysEqual = (keyA, keyB) => {
-	if (keyA.type === 'Identifier') {
-		if (keyB.type === 'Identifier') {
-			return keyA.name === keyB.name;
-		}
-
-		if (keyB.type === 'Literal') {
-			return keyA.name === keyB.value;
-		}
+const getPropertyKeyName = key => {
+	if (key.type === 'Identifier' || key.type === 'JSXIdentifier') {
+		return key.name;
 	}
 
-	if (keyA.type === 'Literal') {
-		if (keyB.type === 'Identifier') {
-			return keyA.value === keyB.name;
-		}
-
-		if (keyB.type === 'Literal') {
-			return keyA.value === keyB.value;
-		}
+	if (key.type === 'Literal') {
+		return key.value;
 	}
+};
 
-	return false;
+const propertyKeysEqual = (keyA, keyB) => {
+	const keyNameA = getPropertyKeyName(keyA);
+	return keyNameA !== undefined && keyNameA === getPropertyKeyName(keyB);
 };
 
 const objectPatternMatchesObjectExprPropertyKey = (pattern, key) =>
@@ -137,7 +128,10 @@ const create = context => {
 						return;
 					}
 
-					if (parent.type === 'MemberExpression') {
+					if (
+						parent.type === 'MemberExpression'
+						|| parent.type === 'JSXMemberExpression'
+					) {
 						if (
 							isMemberExpressionAssignment(parent)
 							|| isMemberExpressionCall(parent)
diff --git a/test/no-unused-properties.js b/test/no-unused-properties.js
@@ -402,6 +402,26 @@ test({
 			`,
 			errors: [error],
 		},
+		{
+			code: outdent`
+				const styles = {
+					wrapper: styled('div', {}),
+					unused: styled('div', {}),
+				};
+
+				function Component() {
+					return <styles.wrapper />;
+				}
+			`,
+			languageOptions: {
+				parserOptions: {
+					ecmaFeatures: {
+						jsx: true,
+					},
+				},
+			},
+			errors: [error],
+		},
 	],
 });
 
