expiring-todo-comments: Fix partial version comparison (#2895)

sindresorhus · web-flow · commit 51390e9d3d62 · 2026-03-05T20:12:11.000+07:00
diff --git a/rules/expiring-todo-comments.js b/rules/expiring-todo-comments.js
@@ -256,11 +256,8 @@ function tryToCoerceVersion(rawVersion) {
 	}
 }
 
-function semverComparisonForOperator(operator) {
-	return {
-		'>': semver.gt,
-		'>=': semver.gte,
-	}[operator];
+function satisfiesRange(version, condition, range) {
+	return semver.satisfies(version, `${condition}${range}`, {includePrerelease: true});
 }
 
 const DEFAULT_OPTIONS = {
@@ -388,10 +385,7 @@ const create = context => {
 			const [{condition, version}] = packageVersions;
 
 			const packageVersion = tryToCoerceVersion(packageJson.version);
-			const decidedPackageVersion = tryToCoerceVersion(version);
-
-			const compare = semverComparisonForOperator(condition);
-			if (packageVersion && compare(packageVersion, decidedPackageVersion)) {
+			if (packageVersion && satisfiesRange(packageVersion, condition, version)) {
 				context.report({
 					loc: sourceCode.getLoc(comment),
 					messageId: MESSAGE_ID_REACHED_PACKAGE_VERSION,
@@ -431,7 +425,6 @@ const create = context => {
 				continue;
 			}
 
-			const todoVersion = tryToCoerceVersion(dependency.version);
 			const targetPackageVersion = tryToCoerceVersion(targetPackageRawVersion);
 
 			/* c8 ignore start */
@@ -441,9 +434,7 @@ const create = context => {
 			}
 			/* c8 ignore end */
 
-			const compare = semverComparisonForOperator(dependency.condition);
-
-			if (compare(targetPackageVersion, todoVersion)) {
+			if (satisfiesRange(targetPackageVersion, dependency.condition, dependency.version)) {
 				context.report({
 					loc: sourceCode.getLoc(comment),
 					messageId: MESSAGE_ID_VERSION_MATCHES,
@@ -468,14 +459,11 @@ const create = context => {
 				continue;
 			}
 
-			const todoEngine = tryToCoerceVersion(engine.version);
 			const targetPackageEngineVersion = tryToCoerceVersion(
 				targetPackageRawEngineVersion,
 			);
 
-			const compare = semverComparisonForOperator(engine.condition);
-
-			if (compare(targetPackageEngineVersion, todoEngine)) {
+			if (targetPackageEngineVersion && satisfiesRange(targetPackageEngineVersion, engine.condition, engine.version)) {
 				context.report({
 					loc: sourceCode.getLoc(comment),
 					messageId: MESSAGE_ID_ENGINE_MATCHES,
diff --git a/test/expiring-todo-comments.js b/test/expiring-todo-comments.js
@@ -59,6 +59,11 @@ test({
 		},
 		'// Expire Condition [2000-01-01]: new term name',
 		'// TODO [>2000]: We sure didnt past this version',
+		// Partial versions should use semver range semantics (#1132)
+		// `>1` means `>=2.0.0`, not `>1.0.0`; `>63` means `>=64.0.0`, not `>63.0.0`
+		'// TODO [>63]: package is 63.0.0 so >63 should not trigger',
+		'// TODO [find-up-simple@>1]: find-up-simple is 1.0.1 so >1 should not trigger',
+		'// TODO [engine:node@>20]: node engine is 20.x so >20 should not trigger',
 		'// TODO [-find-up-simple]: We actually use this.',
 		'// TODO [+popura]: I think we wont need a broken package.',
 		'// TODO [semver@>1000]: Welp hopefully we wont get at that.',
@@ -256,6 +261,10 @@ test({
 			code: '// TODO [@lubien/fixture-beta-package@>=1.0.0-beta.0]: when `@lubien/fixture-beta-package` version is >= 1.0.0-beta.0',
 			errors: [versionMatchesError('@lubien/fixture-beta-package >= 1.0.0-beta.0', 'when `@lubien/fixture-beta-package` version is >= 1.0.0-beta.0')],
 		},
+		{
+			code: '// TODO [@lubien/fixture-beta-package@>0.9]: when `@lubien/fixture-beta-package` prerelease version is > 0.9',
+			errors: [versionMatchesError('@lubien/fixture-beta-package > 0.9', 'when `@lubien/fixture-beta-package` prerelease version is > 0.9')],
+		},
 		{
 			code: '// TODO [semver>1]: Missing @.',
 			errors: [missingAtSymbolError('semver>1', 'semver@>1', 'Missing @.')],
