explicit-length-check: Fix || fallback false positives (#2889)

sindresorhus · web-flow · commit 84246ecd83bd · 2026-02-14T00:20:31.000+07:00
diff --git a/rules/explicit-length-check.js b/rules/explicit-length-check.js
@@ -7,7 +7,7 @@ import {
 	getBooleanAncestor,
 } from './utils/index.js';
 import {fixSpaceAroundKeyword} from './fix/index.js';
-import {isLiteral, isMemberExpression, isNumericLiteral} from './ast/index.js';
+import {isLiteral, isMemberExpression} from './ast/index.js';
 
 const TYPE_NON_ZERO = 'non-zero';
 const TYPE_ZERO = 'zero';
@@ -93,28 +93,6 @@ function getLengthCheckNode(node) {
 	return {};
 }
 
-function isNodeValueNumber(node, context) {
-	if (isNumericLiteral(node)) {
-		return true;
-	}
-
-	const staticValue = getStaticValue(node, context.sourceCode.getScope(node));
-	return staticValue && typeof staticValue.value === 'number';
-}
-
-function isNodeValueString(node, context) {
-	if (node.type === 'Literal' && typeof node.value === 'string') {
-		return true;
-	}
-
-	if (node.type === 'TemplateLiteral') {
-		return true;
-	}
-
-	const staticValue = getStaticValue(node, context.sourceCode.getScope(node));
-	return staticValue && typeof staticValue.value === 'string';
-}
-
 function create(context) {
 	const options = context.options[0];
 	const nonZeroStyle = nonZeroStyles.get(options['non-zero']);
@@ -192,13 +170,7 @@ function create(context) {
 			if (isBooleanNode(ancestor)) {
 				isZeroLengthCheck = isNegative;
 				node = ancestor;
-			} else if (
-				isLogicalExpression(lengthNode.parent)
-				&& !(
-					lengthNode.parent.operator === '||'
-					&& (isNodeValueNumber(lengthNode.parent.right, context) || isNodeValueString(lengthNode.parent.right, context))
-				)
-			) {
+			} else if (isLogicalExpression(lengthNode.parent) && lengthNode.parent.operator === '&&') {
 				isZeroLengthCheck = isNegative;
 				node = lengthNode;
 				autoFix = false;
diff --git a/test/explicit-length-check.js b/test/explicit-length-check.js
@@ -108,40 +108,11 @@ test({
 		'const x = foo.length || `bar`',
 		'const A_STRING = "bar"; const x = foo.length || A_STRING',
 		'const size = props.size || "mini"',
+		'const x = foo.length || unknown',
+		'something(options.length || 500)',
+		'const itemCount = result.totalCount || result.length',
 	],
 	invalid: [
-		suggestionCase({
-			code: 'const x = foo.length || bar()',
-			messageId: TYPE_NON_ZERO,
-			output: 'const x = foo.length > 0 || bar()',
-			desc: 'Replace `.length` with `.length > 0`.',
-		}),
-		suggestionCase({
-			code: 'const x = foo.length || unknown',
-			messageId: TYPE_NON_ZERO,
-			output: 'const x = foo.length > 0 || unknown',
-			desc: 'Replace `.length` with `.length > 0`.',
-		}),
-		suggestionCase({
-			code: 'const NON_NUMBER = true; const x = foo.length || NON_NUMBER',
-			messageId: TYPE_NON_ZERO,
-			output: 'const NON_NUMBER = true; const x = foo.length > 0 || NON_NUMBER',
-			desc: 'Replace `.length` with `.length > 0`.',
-		}),
-		suggestionCase({
-			code: 'const x = foo.length || bar()',
-			messageId: TYPE_NON_ZERO,
-			output: 'const x = foo.length !== 0 || bar()',
-			desc: 'Replace `.length` with `.length !== 0`.',
-			options: [{'non-zero': 'not-equal'}],
-		}),
-		suggestionCase({
-			code: 'const x = foo.length || bar()',
-			messageId: TYPE_NON_ZERO,
-			output: 'const x = foo.length > 0 || bar()',
-			desc: 'Replace `.length` with `.length > 0`.',
-			options: [{'non-zero': 'greater-than'}],
-		}),
 		suggestionCase({
 			code: '() => foo.length && bar()',
 			messageId: TYPE_NON_ZERO,
diff --git a/test/snapshots/explicit-length-check.js.md b/test/snapshots/explicit-length-check.js.md
@@ -1300,7 +1300,7 @@ Generated by [AVA](https://avajs.dev).
       1 | bar(!foo.length || foo.length)␊
     `
 
-> Error 1/2
+> Error 1/1
 
     `␊
     Message:␊
@@ -1311,17 +1311,6 @@ Generated by [AVA](https://avajs.dev).
       1 | bar(foo.length === 0 || foo.length)␊
     `
 
-> Error 2/2
-
-    `␊
-    Message:␊
-    > 1 | bar(!foo.length || foo.length)␊
-        |                    ^^^^^^^^^^ Use \`.length > 0\` when checking length is not zero.␊
-    ␊
-    Suggestion 1/1: Replace \`.length\` with \`.length > 0\`.:␊
-      1 | bar(!foo.length || foo.length > 0)␊
-    `
-
 ## invalid(14): const bar = void !foo.length;
 
 > Input
diff --git a/test/snapshots/explicit-length-check.js.snap b/test/snapshots/explicit-length-check.js.snap
