prefer-export-from: Fix type-import being removed when using namespace import (#2771)

k-yle · web-flow · commit ab4b779a45c8 · 2026-02-10T21:26:52.000+07:00
diff --git a/rules/prefer-export-from.js b/rules/prefer-export-from.js
@@ -86,14 +86,14 @@ function getFixFunction({
 		if (imported.name === NAMESPACE_SPECIFIER_NAME) {
 			yield fixer.insertTextAfter(
 				program,
-				`\nexport * as ${exported.text} ${getSourceAndAssertionsText(importDeclaration, context)}`,
+				`\nexport ${shouldExportAsType ? 'type ' : ''}* as ${exported.text} ${getSourceAndAssertionsText(importDeclaration, context)}`,
 			);
 		} else {
 			let specifierText = exported.name === imported.name
 				? exported.text
 				: `${imported.text} as ${exported.text}`;
 
-			// Add an inline type specifier if the value is a type and the export deceleration is a value deceleration
+			// Add an inline type specifier if the value is a type and the export declaration is a value declaration
 			if (shouldExportAsType && (!exportDeclaration || exportDeclaration.exportKind !== 'type')) {
 				specifierText = `type ${specifierText}`;
 			}
@@ -116,7 +116,8 @@ function getFixFunction({
 			}
 		}
 
-		if (imported.variable.references.length === 1) {
+		const importHasSideEffects = exported.isTypeExport && !imported.isTypeImport;
+		if (imported.variable.references.length === 1 && !importHasSideEffects) {
 			yield removeImportOrExport(imported.node, fixer, context);
 		}
 
diff --git a/test/prefer-export-from.js b/test/prefer-export-from.js
@@ -474,6 +474,22 @@ test.snapshot({
 			export {foo};
 			export {bar} from './foo.json' assert { type: 'unknown' };
 		`,
+		outdent`
+			import type * as X from 'foo';
+			export { X };
+		`,
+		outdent`
+			import * as X from 'foo';
+			export type { X };
+		`,
+		outdent`
+			import type * as X from 'foo';
+			export type { X };
+		`,
+		outdent`
+			import * as X from 'foo';
+			export { X };
+		`,
 	],
 });
 
diff --git a/test/snapshots/prefer-export-from.js.md b/test/snapshots/prefer-export-from.js.md
@@ -1871,7 +1871,7 @@ Generated by [AVA](https://avajs.dev).
         |               ^^^ Use \`export…from\` to re-export \`foo\`.␊
     ␊
     Output:␊
-      1 |␊
+      1 | import { foo } from 'foo';␊
       2 |␊
       3 | export {type foo} from 'foo';␊
     `
@@ -2158,6 +2158,98 @@ Generated by [AVA](https://avajs.dev).
       3 | export {bar, foo} from './foo.json' assert { type: 'unknown' };␊
     `
 
+## invalid(26): import type * as X from 'foo'; export { X };
+
+> Input
+
+    `␊
+      1 | import type * as X from 'foo';␊
+      2 | export { X };␊
+    `
+
+> Error 1/1
+
+    `␊
+    Message:␊
+      1 | import type * as X from 'foo';␊
+    > 2 | export { X };␊
+        |          ^ Use \`export…from\` to re-export \`X\`.␊
+    ␊
+    Output:␊
+      1 |␊
+      2 |␊
+      3 | export type * as X from 'foo';␊
+    `
+
+## invalid(27): import * as X from 'foo'; export type { X };
+
+> Input
+
+    `␊
+      1 | import * as X from 'foo';␊
+      2 | export type { X };␊
+    `
+
+> Error 1/1
+
+    `␊
+    Message:␊
+      1 | import * as X from 'foo';␊
+    > 2 | export type { X };␊
+        |               ^ Use \`export…from\` to re-export \`X\`.␊
+    ␊
+    Output:␊
+      1 | import * as X from 'foo';␊
+      2 |␊
+      3 | export type * as X from 'foo';␊
+    `
+
+## invalid(28): import type * as X from 'foo'; export type { X };
+
+> Input
+
+    `␊
+      1 | import type * as X from 'foo';␊
+      2 | export type { X };␊
+    `
+
+> Error 1/1
+
+    `␊
+    Message:␊
+      1 | import type * as X from 'foo';␊
+    > 2 | export type { X };␊
+        |               ^ Use \`export…from\` to re-export \`X\`.␊
+    ␊
+    Output:␊
+      1 |␊
+      2 |␊
+      3 | export type * as X from 'foo';␊
+    `
+
+## invalid(29): import * as X from 'foo'; export { X };
+
+> Input
+
+    `␊
+      1 | import * as X from 'foo';␊
+      2 | export { X };␊
+    `
+
+> Error 1/1
+
+    `␊
+    Message:␊
+      1 | import * as X from 'foo';␊
+    > 2 | export { X };␊
+        |          ^ Use \`export…from\` to re-export \`X\`.␊
+    ␊
+    Output:␊
+      1 |␊
+      2 |␊
+      3 | export * as X from 'foo';␊
+    `
+
 ## invalid(1): import json from './foo.json' with { type: 'json' }; export default json;
 
 > Input
diff --git a/test/snapshots/prefer-export-from.js.snap b/test/snapshots/prefer-export-from.js.snap

Original file line number	Diff line number	Diff line change
`@@ -86,14 +86,14 @@ function getFixFunction({`
`86`	`86`	`if (imported.name === NAMESPACE_SPECIFIER_NAME) {`
`87`	`87`	`yield fixer.insertTextAfter(`
`88`	`88`	`program,`
`89`		- `\nexport * as ${exported.text} ${getSourceAndAssertionsText(importDeclaration, context)}`,
	`89`	+ `\nexport ${shouldExportAsType ? 'type ' : ''}* as ${exported.text} ${getSourceAndAssertionsText(importDeclaration, context)}`,
`90`	`90`	`);`
`91`	`91`	`} else {`
`92`	`92`	`let specifierText = exported.name === imported.name`
`93`	`93`	`? exported.text`
`94`	`94`	: `${imported.text} as ${exported.text}`;
`95`	`95`
`96`		`- // Add an inline type specifier if the value is a type and the export deceleration is a value deceleration`
	`96`	`+ // Add an inline type specifier if the value is a type and the export declaration is a value declaration`
`97`	`97`	`if (shouldExportAsType && (!exportDeclaration \|\| exportDeclaration.exportKind !== 'type')) {`
`98`	`98`	specifierText = `type ${specifierText}`;
`99`	`99`	`}`
`@@ -116,7 +116,8 @@ function getFixFunction({`
`116`	`116`	`}`
`117`	`117`	`}`
`118`	`118`
`119`		`- if (imported.variable.references.length === 1) {`
	`119`	`+ const importHasSideEffects = exported.isTypeExport && !imported.isTypeImport;`
	`120`	`+ if (imported.variable.references.length === 1 && !importHasSideEffects) {`
`120`	`121`	`yield removeImportOrExport(imported.node, fixer, context);`
`121`	`122`	`}`
`122`	`123`