Allow extra content in CSR file for ReadCertificateRequest#488
Merged
Conversation
maraino
requested changes
Apr 16, 2024
Contributor
maraino
left a comment
There was a problem hiding this comment.
At least we need to support the errors.Is method, but we should be adding your changes to other related methods in this package.
maraino
reviewed
Apr 16, 2024
maraino
requested changes
Apr 18, 2024
maraino
reviewed
Apr 19, 2024
Comment on lines
+320
to
+323
| if e.Type == PEMTypeUndefined { | ||
| return fmt.Sprintf("file %s does not contain valid PEM encoded data", e.File) | ||
| } | ||
| return fmt.Sprintf("file %s does not contain a valid PEM encoded %s", e.File, e.Type) |
Contributor
There was a problem hiding this comment.
It works for now, but the file might not be present if we add this error to methods like ParseCertificate where the arguments are just the PEM bytes.
Comment on lines
+415
to
+416
| return csr, &InvalidPEMError{File: filename, Type: PEMTypeCertificateRequest, | ||
| Err: fmt.Errorf("error parsing %s: CSR PEM block is invalid: %w", filename, err)} |
Contributor
There was a problem hiding this comment.
It would make more sense to set that as the message and set Err: err
maraino
requested changes
Apr 22, 2024
Co-authored-by: Mariano Cano <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.