Add SearchKeys functionality to MacKMS#552
Merged
Conversation
360134c to
9c3c6e2
Compare
bd63571 to
4baf2ce
Compare
maraino
reviewed
Jul 26, 2024
Contributor
maraino
left a comment
There was a problem hiding this comment.
Looks ok, I've added a few questions and a comment to see if it is possible to search keys in the secure enclave. For example, all with the default tag would be mackms:se=true
If `se` is not specified in the search query, all keys managed by the KMS (using the default tag) will be returned. When `se=true`, or `se=false`, keys will be filtered based on whether they were created inside the Secure Enclave or not, respectively.
maraino
approved these changes
Jul 29, 2024
Contributor
maraino
left a comment
There was a problem hiding this comment.
LGTM.
In the switch cases, we could remove the se=false in the name URI, which would be the default for individual keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In follow up PRs I'd like to add: