Allow to retry with no tags when loading privatekeys#631
Merged
Conversation
This function allows to retry the retrieval of a key without tags if the original uri didn't have one. This is used only in GetPublicKey and CreateSigner. It is not used in SearchKeys as we will need to remove duplicated keys.
joshdrake
requested changes
Nov 14, 2024
Contributor
joshdrake
left a comment
There was a problem hiding this comment.
One errant debugging statement, otherwise lgtm.
joshdrake
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This function allows you to retry the load of a key without tags if the original URL didn't have one.
This is used only in GetPublicKey and CreateSigner. It is not used in SearchKeys as duplicate keys must be removed.
cc: @joshdrake