Add pyproject async template to Alembic#1683
Conversation
|
hi - this is just the async + pyproject templates put together right? should be fine |
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 46d03fb of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 46d03fb: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5994 |
Appreciate the quick response. Yes, it is just async + pyproject. |
|
Federico Caselli (CaselIT) wrote: recheck pep8 View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5994 |
|
the pep8 stuff clearly has to do with the newer releases of flake8-import-order, I'll fix all that |
I think it may need changes to zimports to fix. We could pin that plugin for now |
|
Sorry, wrong button |
|
yes, got the new zimports in, the fix w/ the type-checking is a lifesaver |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5994 has been merged. Congratulations! :) |
Added new ``pyproject_async`` template, combining the new ``pyproject`` template with the ``async`` template. Pull request courtesy Alc-Alc. Closes: #1683 Pull-request: sqlalchemy/alembic#1683 Pull-request-sha: 46d03fbff27f9569545854ba9e6ad388892adcfd Change-Id: I4071e069154541bdb1af864982e553bee687222e
Description
This PR adds a new template "pyproject_async"* that can be used to bootstrap environments that want to use async DB-API with a pyproject.toml file. It also includes a minor update to the cookbook to add the name of the new template.
PR is similar to 8196af9 that added an async template.
Checklist
I am not sure if this warrants an issue, but I can create one if needed, my apologies if this is unclear.
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit message* - I have no strong commitments to the name of the template and can be bikeshed if needed. 😄
PS: This was a small change, so no worries at all if the maintainers choose not to proceed with it. 😇
Have a nice day!