fix: update eslint-config-standard-jsx#1775
Merged
theoludwig merged 2 commits intomasterfrom Feb 3, 2022
Merged
Conversation
theoludwig
reviewed
Feb 3, 2022
Contributor
theoludwig
left a comment
There was a problem hiding this comment.
Maybe we can add a test case like we did inside eslint-config-standard to avoid regression.
Member
Author
Good idea, added the very same, but adapted for the |
theoludwig
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need standard/eslint-config-standard-jsx#44 to fix #1548
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Ensuring the
ecmaVersionset ineslint-config-standard-jsxreflects the one set ineslint-config-standardWhich issue (if any) does this pull request address?
Fixes #1548
Is there anything you'd like reviewers to focus on?
Check that this actually fixes the problem.