Fix test of silent exit on unsupported node.js versions#1829
Merged
Fix test of silent exit on unsupported node.js versions#1829
Conversation
theoludwig
suggested changes
Jul 18, 2022
Contributor
theoludwig
left a comment
There was a problem hiding this comment.
Thanks for investigating how to fix the old tests on master.
Some comments need more clarification of what's going on.
While I still think, we should not do some "version guard" things, I don't mind for the moment if we continue to fail silently for the older Node.js versions. About that, I will continue to discuss that in #1828, so this PR only talks about the implementation, not the possible solutions. 😄
c36babb to
f635e4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
version-guardfor the silent exit (this helped identify a mismatch in the version set inbin/cmd.jsand the one inpackage.json).cjsfile ending to avoid having to resort toeval()-index.jsfiles (since there's now acli.jsfile as well) inlib/old-test.yml, to get a a signal of how far back any possible breakage goesold-test-ymlto avoid problems on npm install (this fixed the tests)Which issue (if any) does this pull request address?
Closes #1828
Is there anything you'd like reviewers to focus on?