Skip to content

Fixed version update logic#2674

Merged
prathmesh-stripe merged 1 commit intomasterfrom
prathmesh/fix-justfile
Apr 8, 2026
Merged

Fixed version update logic#2674
prathmesh-stripe merged 1 commit intomasterfrom
prathmesh/fix-justfile

Conversation

@prathmesh-stripe
Copy link
Copy Markdown
Contributor

@prathmesh-stripe prathmesh-stripe commented Apr 8, 2026

Why?

The just update-version recipe was broken after the v22 refactor because the underlying pattern changed.

Both caused stripe.VERSION / Stripe.PACKAGE_VERSION to return the wrong version at runtime.

What?

  • Fixed the perl regex in the justfile to match static PACKAGE_VERSION instead of Stripe.PACKAGE_VERSION
  • Added a second perl command to also update src/stripe.esm.node.ts

@prathmesh-stripe prathmesh-stripe marked this pull request as ready for review April 8, 2026 13:49
@prathmesh-stripe prathmesh-stripe requested a review from a team as a code owner April 8, 2026 13:49
@prathmesh-stripe prathmesh-stripe requested review from mbroshi-stripe and removed request for a team April 8, 2026 13:49
@prathmesh-stripe prathmesh-stripe merged commit 84f3e3a into master Apr 8, 2026
11 checks passed
@prathmesh-stripe prathmesh-stripe deleted the prathmesh/fix-justfile branch April 8, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants