🦋 Changeset detected

Latest commit: e399ef1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	eslint-define-config@​1.24.1
	eslint@​8.57.0
	glob@​8.1.0
	dprint@​0.35.4
	jest@​29.7.0
	expect@​27.5.1
	npm-run-all@​4.1.5
	sourcemap-validator@​2.1.0
	react@​17.0.2
	husky@​7.0.4
	regenerator-runtime@​0.13.11
	reflect-metadata@​0.1.14
	@​types/​node@​20.12.12
	swc-plugin-coverage-instrument@​0.0.26
	js-beautify@​1.14.7
	ts-node@​10.9.1
	prop-types@​15.8.1
	source-map-support@​0.5.21
	tsx@​3.14.0
	octokit@​3.2.1
	zx@​8.1.4
	source-map@​0.7.4
	semver@​7.6.2 ⏵ 7.5.4
	eslint-plugin-n@​16.6.2
	terser@​5.17.6
	typescript@​5.5.4
	typescript@​5.3.3
	prettier@​2.8.8
	yaml@​2.4.5
	cspell@​5.21.2
	mocha@​9.2.2
	webpack@​4.47.0
	lint-staged@​12.5.0

View full report

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		Obfuscated code: npm js-beautify is 100.0% likely obfuscated Confidence: 1.00 Location: Package overview From: package.json → npm/[email protected] ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected]. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Binary Sizes

Commit: e6d35ee

Merging this PR will not alter performance

✅ 219 untouched benchmarks

_{Comparing kdy1/react-compiler-fast-check-only-11751 (e399ef1) with main (7d8d11b)}

PR Review: refactor(react-compiler): remove compiler impl and keep fast_check

Summary

Clean removal of the in-house React Compiler implementation (~122K lines deleted) in preparation for migrating to the official Rust React Compiler (#11751). Only fast_check::is_required is retained — which is the right call since the node binding (binding_react_compiler_node) only depends on that function.

Code Quality

• lib.rs is now minimal and clean — just #![deny(clippy::all)] and pub mod fast_check. Good.
• Cargo.toml dependencies are properly trimmed: swc_atoms, swc_ecma_codegen, and serde_json are removed since they were only used by the deleted compiler code. swc_common is correctly moved to [dev-dependencies] (needed by the inline tests in fast_check.rs).
• CI.yml cleanup is correct — the swc_ecma_react_compiler special-case with REACT_COMPILER_FIXTURE_ALLOW_FAILURE is no longer needed, and the crate now runs through the standard test path.
• Changeset correctly marks this as a major version bump, which is appropriate given the removed public API surface.

Potential Concerns

1. Downstream re-export via swc_core: swc_core re-exports swc_ecma_react_compiler as react_compiler behind the ecma_react_compiler feature flag. After this PR, consumers using swc_core::react_compiler::react_compiler(), CompilerPass, ParsedPluginOptions, etc. will break. This is expected for a major bump, but worth confirming that no first-party consumer (e.g., swc main crate) depends on those removed exports. The binding_react_compiler_node only uses fast_check::is_required, so that's fine.

2. fast_check.rs — minor early-exit optimization opportunity: The visit_var_declarator implementation visits all children even when self.found is already true. The visit_stmt and visit_expr methods have early exits for self.found, but visit_var_declarator and the other visitors don't. This is pre-existing and not introduced by this PR, but worth noting as a potential follow-up since this is now the only code in the crate.

3. No fast_check module-level doc comment: Since this is now the entire public surface of the crate, a brief doc comment on pub fn is_required explaining what "required" means (i.e., the program contains React components or hooks that would benefit from compilation) would help consumers. Again, pre-existing — not a blocker.

Test Coverage

• The inline #[cfg(test)] tests in fast_check.rs are preserved and cover the key cases: components with JSX, hooks usage, arrow functions, export defaults, and negative cases. This is adequate for the remaining functionality.
• Fixture tests for the removed compiler are correctly deleted.
• The CI change ensures swc_ecma_react_compiler now runs through the standard test path without the REACT_COMPILER_FIXTURE_ALLOW_FAILURE env var — good cleanup.

Security

No concerns — this is purely a deletion of code.

Performance

No concerns — the remaining fast_check::is_required is a single-pass AST visitor with early exits, which is efficient.

Verdict

Looks good. This is a straightforward, well-scoped deletion that correctly preserves the only actively-used API (fast_check::is_required) and properly updates dependencies, CI, and versioning. The PR description's verification checklist is thorough.

🤖 Generated with Claude Code