fix(worker): resume processing after pause with doNotWaitActive#3974
fix(worker): resume processing after pause with doNotWaitActive#3974roggervalf merged 4 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a Worker state-machine edge case where calling pause(true) (doNotWaitActive) could leave the worker unable to resume job processing, addressing issue #3971.
Changes:
- Adjust
Worker.resume()to work even whenthis.running === truebut the worker is paused. - Restart the stalled checker when resuming from a doNotWaitActive pause.
- Add a regression test covering pause(true) + resume() behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/classes/worker.ts |
Updates resume() logic to unpause even when the main loop is still running and restarts stalled checks. |
tests/worker.test.ts |
Adds a test to ensure processing continues after pause(true) followed by resume(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b6886fb to
926b868
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f27a026 to
c125c1a
Compare
…orget error handling Agent-Logs-Url: https://github.com/taskforcesh/bullmq/sessions/f8f8a013-ecae-4c49-bdab-aa4f59ca67ce Co-authored-by: roggervalf <[email protected]>
e42f050 to
fa73a38
Compare
|
🎉 This PR is included in version 5.73.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.20.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Why
How
Enter the implementation details here.
Additional Notes (Optional)
fixes #3971