fix(job): use consistent grammar in error message#3987
Merged
roggervalf merged 1 commit intotaskforcesh:masterfrom Apr 11, 2026
Merged
fix(job): use consistent grammar in error message#3987roggervalf merged 1 commit intotaskforcesh:masterfrom
roggervalf merged 1 commit intotaskforcesh:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the grammar of a validation error message in Job.validateOptions by changing “could not be used together” to “cannot be used together”, and updates the corresponding test to match.
Changes:
- Update the delay+repeat mutual-exclusion error message in
src/classes/job.ts. - Update
tests/job.test.tsto assert the new error string.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/classes/job.ts |
Aligns the delay+repeat validation error message with other “cannot be used together” messages in the same validator. |
tests/job.test.ts |
Updates the rejection assertion to match the new error message text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
roggervalf
approved these changes
Apr 11, 2026
Contributor
|
🎉 This PR is included in version 5.73.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 2.20.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a minor grammar inconsistency in an error message in
src/classes/job.ts.The error thrown when both
delayandrepeatoptions are provided used the awkward phrasingcould not be used together, while all other similar validation error messages in the same file (e.g., for deduplication, debounce, and exclusive options) usecannot be used together.Changes
src/classes/job.ts: ChangeDelay and repeat options could not be used togethertoDelay and repeat options cannot be used togethertests/job.test.ts: Update the corresponding test assertion to match the new error messageTest plan
tests/job.test.tsto match the new error message