cleanup of minor warnings

John J. Aylward · John J. Aylward · commit bc347d2c1931 · 2018-10-02T15:28:24.000-04:00
diff --git a/JSONArray.java b/JSONArray.java
@@ -1491,7 +1491,7 @@ public List<Object> toList() {
      * @return true if JSONArray is empty, otherwise false.
      */
     public boolean isEmpty() {
-        return myArrayList.isEmpty();
+        return this.myArrayList.isEmpty();
     }
 
 }
diff --git a/JSONPointer.java b/JSONPointer.java
@@ -233,8 +233,8 @@ private Object readByIndexToken(Object current, String indexToken) throws JSONPo
             int index = Integer.parseInt(indexToken);
             JSONArray currentArr = (JSONArray) current;
             if (index >= currentArr.length()) {
-                throw new JSONPointerException(format("index %d is out of bounds - the array has %d elements", index,
-                        currentArr.length()));
+                throw new JSONPointerException(format("index %s is out of bounds - the array has %d elements", indexToken,
+                        Integer.valueOf(currentArr.length())));
             }
             try {
 				return currentArr.get(index);
diff --git a/JSONWriter.java b/JSONWriter.java
@@ -1,7 +1,6 @@
 package org.json;
 
 import java.io.IOException;
-import java.math.BigDecimal;
 import java.util.Collection;
 import java.util.Map;
 
diff --git a/XMLTokener.java b/XMLTokener.java
@@ -135,7 +135,7 @@ public Object nextContent() throws JSONException {
      * @return  A Character or an entity String if the entity is not recognized.
      * @throws JSONException If missing ';' in XML entity.
      */
-    public Object nextEntity(char ampersand) throws JSONException {
+    public Object nextEntity(@SuppressWarnings("unused") char ampersand) throws JSONException {
         StringBuilder sb = new StringBuilder();
         for (;;) {
             char c = next();

Original file line number	Diff line number	Diff line change
`@@ -1491,7 +1491,7 @@ public List<Object> toList() {`
`1491`	`1491`	`* @return true if JSONArray is empty, otherwise false.`
`1492`	`1492`	`*/`
`1493`	`1493`	`public boolean isEmpty() {`
`1494`		`- return myArrayList.isEmpty();`
	`1494`	`+ return this.myArrayList.isEmpty();`
`1495`	`1495`	`}`
`1496`	`1496`
`1497`	`1497`	`}`