Merged
Conversation
Unfortunately, making type inference work for this requires removing the generic parameter from ServiceExt, which in turn requires removing the tower::Service supertrait. This made the Sealed trait useless, and while I was at it I also removed the Sized supertrait in favor of Sized bounds on all current trait methods (this allows backwards-compatibly adding methods that don't require Self to be Sized to be added). This means that now you can call all of these methods on _anything_, the resulting type just isn't going to be very useful if the type you're calling the method on isn't a tower::Service<http::Request<B>> (extra bounds may apply depending on the exact method).
Collaborator
|
Just curious, I didn't see an issue or someone point out compilation errors. Is there an example somewhere of what was broken? |
Member
Author
|
Type inference couldn't figure out |
LucioFranco
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, making type inference work for this requires removing the generic parameter from
ServiceExt, which in turn requires removing thetower::Servicesupertrait. This made theSealedtrait useless, and while I was at it I also removed theSizedsupertrait in favor ofSizedbounds on all current trait methods (this allows backwards-compatibly adding methods that don't require Self to be Sized to be added).This means that now you can call all of these methods on anything, the resulting type just isn't going to be very useful if the type you're calling the method on isn't a
tower::Service<http::Request<B>>(extra bounds may apply depending on the exact method).I also tested that this works in a real-world setting.
I think the only realistic alternative to this is not having
ServiceExtat all.