Add decorator-related diagnostic codes to expectError#207
Merged
sindresorhus merged 2 commits intotsdjs:mainfrom Jan 17, 2024
Merged
Add decorator-related diagnostic codes to expectError#207sindresorhus merged 2 commits intotsdjs:mainfrom
sindresorhus merged 2 commits intotsdjs:mainfrom
Conversation
…errors There are a few diagnostic codes that are < 2000 but aren't really syntactical errors. They can thus be listed in expectErrorDiagnosticCodesToIgnore to be "expected" by expecteError.
This was referenced Jul 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because diagnostic codes are < 2000 (and therefore deemed "syntactical errors"), the ignore logic needs to be adapted.
Fixes #206