fix: avoid dev-server crash when ws proxy error#12829
Merged
patak-cat merged 1 commit intovitejs:mainfrom May 8, 2023
Merged
Conversation
|
|
Member
|
While this PR seems to make sense, a small reproduction of the error would really help be sure this block is needed and the error was not fixed by previous commit as pointed in the linked issue |
Contributor
Author
or run the demo navigate to /grafana or /test |
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Member
|
Is the ecosystem CI running with an old main base maybe? |
patak-cat
approved these changes
May 8, 2023
Member
patak-cat
left a comment
There was a problem hiding this comment.
Yes, the PR is using a month-old state of main. Let's merge this one 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #12664
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).