fix: call tryFsResolve for relative new URL(foo, import.meta.url)#13142
Merged
patak-cat merged 3 commits intovitejs:mainfrom May 10, 2023
Merged
fix: call tryFsResolve for relative new URL(foo, import.meta.url)#13142patak-cat merged 3 commits intovitejs:mainfrom
tryFsResolve for relative new URL(foo, import.meta.url)#13142patak-cat merged 3 commits intovitejs:mainfrom
Conversation
|
|
new URL(foo, import.meta.url)tryFsResolve for relative new URL(foo, import.meta.url)
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Member
Given that this was working in 4.2, I think it is a good idea to move forward with your PR. We can discuss the breaking change for Vite 5, but I think we may need to keep supporting this. |
patak-cat
approved these changes
May 10, 2023
Member
patak-cat
left a comment
There was a problem hiding this comment.
Nuxt and Astro are also failing in main
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
new URL('./path-without-extension', import.meta.url)was supported in past but wasn't working since 4.3. This was caused by #12450.fixes #13141
refs #7837
Additional context
I wonder if we should remove these resolvings from
new URL(foo, import.meta.url)(i.e. only support relative paths with extensions) asnew URLis a constructor that simply resolves relative paths. Instead to introduceimport.meta.resolvefor that usage asimport.meta.resolvewill resolve like node and it works with Node.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).