fix: htmlFallbackMiddleware for favicon#15301
Merged
Conversation
|
|
ArnaudBarre
previously approved these changes
Dec 10, 2023
bluwy
reviewed
Dec 11, 2023
Member
bluwy
left a comment
There was a problem hiding this comment.
I think it was intentional that the html fallback also apply to images, especially when we removed the dot rule. Perhaps we could special case for favicon.ico only? cc @sapphi-red
Member
|
Yeah, if |
Member
Author
|
Thanks! Updated to directly avoid the default |
bluwy
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A favicon.ico request is returning the index.html because it has
*/*in its header. It seems that checking againstimage/should work.What is the purpose of this pull request?