Skip to content

fix: missing warmupRequest in transformIndexHtml#15303

Merged
patak-cat merged 3 commits intomainfrom
fix/missing-pretransform-request
Dec 11, 2023
Merged

fix: missing warmupRequest in transformIndexHtml#15303
patak-cat merged 3 commits intomainfrom
fix/missing-pretransform-request

Conversation

@patak-cat
Copy link
Copy Markdown
Member

@patak-cat patak-cat commented Dec 10, 2023

Description

We missed a branch to warmup when processing the HTML files. --open didn't trigger the static imports pre-warmup in https://github.com/sapphi-red/performance-compare

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz bot commented Dec 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-cat patak-cat added the performance Performance related enhancement label Dec 10, 2023
@patak-cat
Copy link
Copy Markdown
Member Author

patak-cat commented Dec 10, 2023

I don't know why the HMR and CSS tests are failing, making this one a draft for now 🤔

@patak-cat patak-cat marked this pull request as draft December 10, 2023 17:09
@patak-cat patak-cat marked this pull request as ready for review December 10, 2023 19:27
@patak-cat
Copy link
Copy Markdown
Member Author

patak-cat commented Dec 10, 2023

Ok, got it now

@patak-cat
Copy link
Copy Markdown
Member Author

patak-cat commented Dec 10, 2023

/ecosystem-ci run

@vite-ecosystem-ci
Copy link
Copy Markdown

vite-ecosystem-ci bot commented Dec 10, 2023

📝 Ran ecosystem CI on c244380: Open

suite result latest scheduled
analogjs ✅ success ✅ success
astro ✅ success ✅ success
histoire ✅ success ✅ success
ladle ✅ success ✅ success
laravel ❌ failure ❌ failure
marko ✅ success ✅ success
nuxt ❌ failure ❌ failure
nx ✅ success ✅ success
previewjs ✅ success ✅ success
qwik ✅ success ✅ success
rakkas ✅ success ✅ success
sveltekit ✅ success ✅ success
unocss ✅ success ✅ success
vike ✅ success ✅ success
vite-plugin-pwa ✅ success ✅ success
vite-plugin-react ✅ success ✅ success
vite-plugin-react-pages ✅ success ✅ success
vite-plugin-react-swc ✅ success ✅ success
vite-plugin-svelte ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vite-setup-catalogue ✅ success ✅ success
vitepress ✅ success ✅ success
vitest ✅ success ✅ success

ArnaudBarre
ArnaudBarre reviewed Dec 10, 2023
View reviewed changes
Comment thread packages/vite/src/node/server/middlewares/indexHtml.ts Outdated
@patak-cat patak-cat merged commit 103820f into main Dec 11, 2023
@patak-cat patak-cat deleted the fix/missing-pretransform-request branch December 11, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArnaudBarre ArnaudBarre ArnaudBarre left review comments

@bluwy bluwy bluwy approved these changes

Assignees

No one assigned

Labels

performance Performance related enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@patak-cat @ArnaudBarre @bluwy