fix(types): remove the keepProcessEnv from the DefaultEnvironmentOptions type#19796
Merged
patak-cat merged 1 commit intovitejs:mainfrom Apr 7, 2025
Conversation
… type the changes here remove the `keepProcessEnv` field from the `DefaultEnvironmentOptions` type, which incorrectly includes it giving the impression that it at the top level vite configuration object (however doing it there doesn't have any effect and the field needs to be applied to specific environments)
74ce7c8 to
14a493f
Compare
keepProcessEnv from the DefaultEnvironmentOptions typekeepProcessEnv from the DefaultEnvironmentOptions type
keepProcessEnv from the DefaultEnvironmentOptions typekeepProcessEnv from the DefaultEnvironmentOptions type
patak-cat
approved these changes
Apr 7, 2025
Member
patak-cat
left a comment
There was a problem hiding this comment.
We don't have many options that don't have a default, and it will be good we keep it that way but in this particular case any default value will be confusing so this sounds good to me too. Thanks!
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the changes here remove the
keepProcessEnvfield from theDefaultEnvironmentOptionstype, which incorrectly includes it giving the impression that it at the top level vite configuration object (however doing it there doesn't have any effect and the field needs to be applied to specific environments)cc. @sapphi-red