Skip to content

chore: more eslint rules#19667

Merged
alexander-akait merged 5 commits intomainfrom
eslimt-more-rules
Jul 8, 2025
Merged

chore: more eslint rules#19667
alexander-akait merged 5 commits intomainfrom
eslimt-more-rules

Conversation

@alexander-akait
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

enable more eslint rules, less todos

Did you add tests for your changes?

Existing

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

Nothing

@alexander-akait alexander-akait changed the title Eslimt more rules chore: more eslint rules Jul 8, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 8, 2025

CodSpeed Performance Report

Merging #19667 will degrade performances by 13%

Comparing eslimt-more-rules (500cf36) with main (260f85e)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 130 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 37.4 ms 43 ms -13%
benchmark "devtool-eval-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 42.7 ms 11.6 ms ×3.7
benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 64.8 ms 50.2 ms +28.99%

@alexander-akait alexander-akait merged commit 5a204dc into main Jul 8, 2025
42 of 44 checks passed
@alexander-akait alexander-akait deleted the eslimt-more-rules branch July 8, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant