test: more case about cjs bundle to esm lib#19787
Merged
alexander-akait merged 3 commits intomainfrom Aug 12, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #19787 will degrade performances by 63.1%Comparing Summary
Benchmarks breakdown
|
| @@ -0,0 +1,3 @@ | |||
| console.log(exports) | |||
| console.log(module) | |||
| console.log(this) No newline at end of file | |||
Member
There was a problem hiding this comment.
Can we avoid using console.log, it outputs a lot of span into CI output, ideally we should remove console.log and debugger from all tests (except where we need it)
|
|
||
| module.exports = { | ||
| name: "overrides-exports-cjs" | ||
| }; |
Member
There was a problem hiding this comment.
let's add a test case:
module.exports = {
name: "adding-exports-cjs"
};
module.exports.foo = "foo";| expect(lib3.name).toBe("overrides-exports-cjs"); | ||
| expect(lib3.foo).toBe(undefined); | ||
| expect(lib4).toMatchObject({}); | ||
| expect(lib5).toMatchObject({}); |
Member
There was a problem hiding this comment.
Is it expected, because I think we should have adding-exports-cjs and foo
alexander-akait
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add more test case.
Did you add tests for your changes?
Yes, feel free to more requirement
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No