-
Notifications
You must be signed in to change notification settings - Fork 106
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: zip-rs/zip2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.3.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: zip-rs/zip2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.4.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 14 files changed
- 4 contributors
Commits on Mar 22, 2026
-
perf: skip BufReader for Stored files in make_reader (#739)
* perf: skip BufReader for Stored files in make_reader Problem: by_index() allocates an 8 KiB BufReader and a Decompressor for every entry, even CompressionMethod::Stored where decompression is a no-op pass-through. For a 23K-entry JAR (mostly Stored files), this means 2 heap allocations per call totaling 8,632 bytes each — 47,262 allocations just to iterate and drop. Fix: add a ZipFileReader::Stored variant that wraps CryptoReader directly in Crc32Reader, bypassing both BufReader and Decompressor. This required adding a Debug impl for CryptoReader since the new Stored variant needs it for the derive(Debug) on ZipFileReader. Measured on bazel.jar (23,631 Stored entries): by_index() allocations: before: 2.0 allocs/entry, 8,632 bytes alloc'd each after: 1.0 allocs/entry, 256 bytes alloc'd each cargo bench read_entry (1 MiB Stored file): before: 106,657 ns/iter (9,831 MB/s) after: 101,276 ns/iter (10,353 MB/s, +5.3%) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> * move Debug defition after type and add debug information for Aes * cargo fmt --------- Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]> Co-authored-by: n4n5 <[email protected]>Configuration menu - View commit details
-
Copy full SHA for c2999bc - Browse repository at this point
Copy the full SHA c2999bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5813c5 - Browse repository at this point
Copy the full SHA f5813c5View commit details -
refactor: split part of
read.rsfor code readability (#744)* refactor: part of read.rs * add reader mod * move to zip_archive * move * re-add imports * move tests * move again * revert fmt * fmt * fix tests * move aes info * move function * move from reader.rs to readers.rs * self contained test * move more reader to readers * typos * fmt and fix CI * use macros * cargo fmt * cargo fmt
Configuration menu - View commit details
-
Copy full SHA for bae095b - Browse repository at this point
Copy the full SHA bae095bView commit details
Commits on Mar 23, 2026
-
chore: move pull request template to correct folder (#749)
* chore: move template to correct place * fix: edit template
Configuration menu - View commit details
-
Copy full SHA for abc0424 - Browse repository at this point
Copy the full SHA abc0424View commit details -
feat: add a check for building benches (#748)
* feat: add a check for building benches * Trigger CI
Configuration menu - View commit details
-
Copy full SHA for f5e7fd5 - Browse repository at this point
Copy the full SHA f5e7fd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a73f55b - Browse repository at this point
Copy the full SHA a73f55bView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v8.3.1...v8.4.0