warning C4003: not enough actual parameters for macro 'max' - Visual Studio 2010 C++

Question

I have the following warnings while compiling an openFrameworks 007 project on Visual Studio 2010 SP1:

d:\pedro\development\videoflow\openframeworks\libs\openframeworks\types\ofcolor.h(127): warning C4003: not enough actual parameters for macro 'max'
d:\pedro\development\videoflow\openframeworks\libs\openframeworks\types\ofcolor.h(128): warning C4003: not enough actual parameters for macro 'max'
d:\pedro\development\videoflow\openframeworks\libs\openframeworks\graphics\ofpixels.h(150): warning C4003: not enough actual parameters for macro 'max'
d:\pedro\development\videoflow\openframeworks\libs\openframeworks\graphics\ofpixels.h(151): warning C4003: not enough actual parameters for macro 'max'

From what I could tell this warnings are usually followed by errors but in my case everything works ok. The affected code is below:

const float srcMax = ( (sizeof(SrcType) == sizeof(float) ) ? 1.f : numeric_limits<SrcType>::max() );
const float dstMax = ( (sizeof(PixelType) == sizeof(float) ) ? 1.f : numeric_limits<PixelType>::max() );

I tried to set NOMINMAX on the preprocessor but since openFrameworks also defines NOMINMAX on ofConstants.h I get a bunch of warnings that NOMINMAX is already defined.

I have tried to define NOMINMAX on the affected openFrameworks files but it results on the same warning (in fact if I analyze the files included on ofColor.h and ofPixel.h they end up including ofConstants.h so NOMINMAX should be defined).

Any idea on how to solve this? If you don't... what would be best? This warnings or a bunch of warnings that NOMINMAX is already defined?

EDIT:

BTW when I talked about errors I was talking about these: warning C4003 and errors C2589 and C2059 on: x = std::numeric_limits<int>::max();

I get this (the warning plus 2 errors) if I try to reproduce the problem on a clean C++ project. But on my openFrameworks project I just get the warnings. That's why I get confused!!

Zitrax · Accepted Answer · 2017-08-24 14:03:57Z

89

You are not the first to be bitten by these ancient macros. They can't remove them, that would break old code. So they came up with another macro to remove the sting. Make it look like this:

#ifndef NOMINMAX
# define NOMINMAX
#endif
#include <windows.h>
// Rest of your #includes here
//...

edited Aug 24, 2017 at 14:03

Zitrax

20.8k22 gold badges102 silver badges116 bronze badges

answered Jul 30, 2011 at 15:50

Hans Passant

948k151 gold badges1.8k silver badges2.6k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

MSalters Over a year ago

And to avoid warnings about redefinition, #ifndef NOMINMAX #define NOMINMAX #endif #include <windows.h>

Seth Carnegie · Accepted Answer · 2011-07-30 15:24:29Z

53

Add #undef max to the top of the relevant files.

answered Jul 30, 2011 at 15:24

Seth Carnegie

75.4k22 gold badges186 silver badges252 bronze badges

7 Comments

Puppy Over a year ago

Don't forget to #ifdef max first.

Seth Carnegie Over a year ago

@DeadMG why? Is it just good style? I tried it on IdeOne and didn't get any warnings or errors.

petersaints Over a year ago

The problem is that the file in question is no my code. It's openFrameworks' code and changing a libraries source code might be a PITA later if the library gets updated.

James McNellis Over a year ago

@DeadMG: It is permitted to #undef max (or any other identifier), even if it is not defined as a macro.

petersaints Over a year ago

I ended up being able to find where the problem was. I was including somewhere else on my code winsock2.h and ws2tcpip.h and these files include windows.h and that was causing the problem. I put #define NOMAXMIN before the includes and it works like a charm now. Neverthless I'm accepting this is answer because it's the correct one to "disable" the min/max macro defined on windows.h while the other answer provides the right thing to do from the start (which is the best thing to do if possible but not really the problem I was facing in the first place).

|

Dmitry Kuzminov · Accepted Answer · 2019-10-19 03:29:27Z

1

#pragma warning (disable: 4003)

edited Oct 19, 2019 at 3:29

Dmitry Kuzminov

6,6758 gold badges26 silver badges50 bronze badges

answered Oct 18, 2019 at 23:57

Alex

1311 silver badge3 bronze badges

Comments

m7913d · Accepted Answer · 2020-11-10 10:47:46Z

1

#ifdef _WIN32
#pragma warning(push)
#pragma warning(disable : 4003) 
#endif

... // code with min/max warning you wish to suppress

#ifdef _WIN32
#pragma warning(pop)
#endif

edited Nov 10, 2020 at 10:47

m7913d

11.1k7 gold badges34 silver badges66 bronze badges

answered Nov 10, 2020 at 10:23

user3103989

312 bronze badges

1 Comment

m7913d Over a year ago

Can you explain your answer, provide a link to relevant official documentation and explain why this answer/solution is better than/preferred over the other(s)?

Collectives™ on Stack Overflow

warning C4003: not enough actual parameters for macro 'max' - Visual Studio 2010 C++

4 Answers 4

1 Comment

7 Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

7 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related