Overloads shouldn't gain @deprecated tags of other overloads in quick info#50904
Merged
sandersn merged 2 commits intomicrosoft:mainfrom Oct 11, 2022
Merged
Overloads shouldn't gain @deprecated tags of other overloads in quick info#50904sandersn merged 2 commits intomicrosoft:mainfrom
sandersn merged 2 commits intomicrosoft:mainfrom
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49368
This PR updates the hover text for overloaded function signatures: it prevents the
@deprecatedJSDoc tag from being passed on to other signatures of the same overloaded function (see the linked issue for examples).This is relevant because it enables the author of the module to deprecate only certain signatures. This behaviour also now aligns the hover text with the existing behaviour of the VS Code "strikethrough" styling.
Please verify that:
Backlogmilestone (required)mainbranchgulp runtestslocally