Allow Unicode extended escapes in ES5 and earlier#50918
Merged
DanielRosenwasser merged 12 commits intomainfrom Sep 30, 2022
Merged
Allow Unicode extended escapes in ES5 and earlier#50918DanielRosenwasser merged 12 commits intomainfrom
DanielRosenwasser merged 12 commits intomainfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, I suppose because we didn't want to support emit fully, we didn't parse out Unicode extended escape sequences; however, it doesn't make sense for us not to parse them.
This PR allows us to successfully parse Unicode extended escapes in all language versions, and also emits them without any escapes when emitting to any target lower than ES2015. If we don't want to add new parameters to
createIdentifier, I can just add the new tracking information separately in the parser, or we can swap this to just being an error.Part of support for #50883.
Fixes #50935.