Check nested weak types in intersections on target side of relation#51140
Merged
ahejlsberg merged 5 commits intomainfrom Oct 13, 2022
Merged
Check nested weak types in intersections on target side of relation#51140ahejlsberg merged 5 commits intomainfrom
ahejlsberg merged 5 commits intomainfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51043.
This PR also moves some intersection property check logic from
isRelatedTotostructuredTypeRelatedTo(i.e. from the un-cached to the cached side of relationship checking). This allows us to get rid of a separate cache lookup and two associatedIntersectionStateflags.