Unconditionally call checkExpression from checkSatisfiesExpression#51704
Merged
RyanCavanaugh merged 2 commits intomicrosoft:mainfrom Dec 1, 2022
Merged
Unconditionally call checkExpression from checkSatisfiesExpression#51704RyanCavanaugh merged 2 commits intomicrosoft:mainfrom
checkExpression from checkSatisfiesExpression#51704RyanCavanaugh merged 2 commits intomicrosoft:mainfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unenforced invariant of our checker is that all subcalls of
checkExpressionmust unconditionally callcheckExpressionon their children in order for emit to work.checkSatisfiesExpressionbroke this by bailing early when the asserted type was invalid, thus breaking the example shown in the OP and testcasePlayground link showing the problem
Fixes #51642. Propose to port to 4.9.