Skip to content

fix(jest-mock): ensure mock resolved and rejected values are promises from correct realm#13503

Merged
SimenB merged 2 commits intojestjs:mainfrom
SimenB:mock-function-promise-instanceof
Oct 24, 2022
Merged

fix(jest-mock): ensure mock resolved and rejected values are promises from correct realm#13503
SimenB merged 2 commits intojestjs:mainfrom
SimenB:mock-function-promise-instanceof

Conversation

@SimenB
Copy link
Copy Markdown
Member

@SimenB SimenB commented Oct 24, 2022

Summary

Fixes #6645

Test plan

Test added, so Green CI

@mhombach
Copy link
Copy Markdown

This also fixes #13206 , right? :)

@SimenB
Copy link
Copy Markdown
Member Author

SimenB commented Oct 24, 2022

Possibly! 🙂 Original repo there gives me ReferenceError: fakeAsync is not defined. But it fixes the instanceof issue

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mockResolvedValue / mockRejectedValue should returns a real Promise

3 participants