docs: improve custom puppeteer example to prevent worker warnings#13619
Merged
SimenB merged 1 commit intojestjs:mainfrom Jan 1, 2023
Merged
docs: improve custom puppeteer example to prevent worker warnings#13619SimenB merged 1 commit intojestjs:mainfrom
SimenB merged 1 commit intojestjs:mainfrom
Conversation
SimenB
approved these changes
Nov 17, 2022
Member
SimenB
left a comment
There was a problem hiding this comment.
thanks! can you update all versions of this doc?
Prevents from warnings: A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.
f35463a to
e0f0fe3
Compare
Contributor
Author
|
@SimenB Sure thing, done. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Environment have to call
disconnectduring teardown otherwise it will generate a warning:Test plan
Just docs update ✌️