Downgrade write-file-atomic to v4#13853
Merged
SimenB merged 3 commits intojestjs:mainfrom Feb 7, 2023
Merged
Conversation
SimenB
approved these changes
Feb 7, 2023
Member
SimenB
left a comment
There was a problem hiding this comment.
Thanks! 👍 Didn't notice write-file-atomic range being outside of our own
247e450 to
b4c01e2
Compare
Member
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hello! When trying to install the latest version of Jest (v29.4.1) I'm getting the following error when using yarn:
[email protected]: The engine "node" is incompatible with this module. Expected version "^14.17.0 || ^16.13.0 || >=18.0.0". Got "16.10.0". Unfortunately, upgrading my project's node version is a large undertaking that will take a lot of time and involve a couple different teams. So I wanted to pass by you the idea of downgrading write-file-atomic for the time being so I can take advantage of the latest Jest features before upgrading my Node version (and perhaps make upgrading easier for anyone else in a similar situation using Node < 16.13 + yarn). Though I understand if you'd rather not. Just thought I'd ask 😊Some additional context:
In v29.4.0 in PR #13703, the
write-file-atomicwas upgraded from v4.0.1 to v5.0.0. Glancing at the changes from v4.0.2...v5.0.0 in write-file-atomic (changelog, commits), I don't see any code changes besides the engines bump. So I believe it is safe to downgrade.Test plan
Tests pass locally for me.