fix(@jest/transform): do not attempt instrumenting .json modules#14048
Merged
SimenB merged 5 commits intojestjs:mainfrom Apr 8, 2023
mrazauskas:fix-do-not-instrument-json-modules
Merged
fix(@jest/transform): do not attempt instrumenting .json modules#14048SimenB merged 5 commits intojestjs:mainfrom mrazauskas:fix-do-not-instrument-json-modules
.json modules#14048SimenB merged 5 commits intojestjs:mainfrom
mrazauskas:fix-do-not-instrument-json-modules
Conversation
mrazauskas
commented
Apr 5, 2023
SimenB
reviewed
Apr 8, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13980
Summary
Currently Babel coverage provider is attempting to collect coverage collection from imported
.jsonfiles, because in ESM these are treated as just another modules.This PR is adding a check in
shouldInstrument()function to exclude.jsonfiles. It is still possible to override this usingforceCoverageMatchoption.Test plan
Unit tests added.