Merged
Conversation
Include `columnOffset` property for `Script` allowing vscode to match the original file with the wrapped `Script` contents.
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
SimenB
approved these changes
May 22, 2023
Member
SimenB
left a comment
There was a problem hiding this comment.
thanks! 👍
Could you add a changelog entry and sign the CLA?
Add fix description
Fixes `Expected object keys to be in ascending order. 'columnOffset' should be before 'filename'`
Member
|
Could you update the failing snapshots? Seems to only be |
SimenB
approved these changes
Jun 21, 2023
Member
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include
columnOffsetproperty forScriptallowing vscode to match the original file with the wrappedScriptcontents.Summary
When debugging inside a jest test the vscode debugger is struggling to source map variables correctly. This applies for the hover variables and any debugger console vm scripts. This issue can be solved by setting
transformas{}, but this comes with the side effect that now the original file can no longer be matched as the contents of the script includes the wrapper.The length of the wrapper was already being tracked when applying the transformation. This information was only never passed along to the
Scriptconstructor.Test plan
node docs