Upgrade ASM to 9.7 by merks · Pull Request #1600 · jacoco/jacoco

merks · 2024-03-24T09:03:26Z

merks · 2024-03-24T09:07:58Z

I tried to reproduce the corresponding changes for this PR that I saw for the following PR's changes for upgrading from 9.5 to 9.6:

#1518

marchof

Welcome @merks here at the JaCoCo project! Looks good to me except the change log entry.

Fixes jacoco#1599

merks · 2024-03-25T08:44:53Z

Thanks guys! I'll try to get the PR fully correct the next time...

merks · 2024-03-25T09:10:52Z

If the link is to the PR rather than the issue, it's not actually possible to get it right until one first creates the PR. Of course typically it's the issue +1, but I'm not sure that this is always the case. Anyway, just thinking of the process the next time this comes up...

Godin · 2024-03-25T09:34:16Z

I'll try to get the PR fully correct the next time

Thanks for this PR ❤️ And no worries - slight polishing by us is not a big deal 👐

Previously we've been quite proactive with ASM updates thanks to a subscription to their mailing list, but seems that they haven't done announcements for the past two versions 😞

it's not actually possible to get it right until one first creates the PR

Usually changelog modification is the very last commit and PR is first opened without this modification 😉

but I'm not sure that this is always the case

You have to believe me that this is true for the existing entries or at least for the majority.

Godin

For the record
here is a link to their changelog - https://asm.ow2.io/versions.html
and actual changes between versions - https://gitlab.ow2.org/asm/asm/-/compare/ASM_9_6...ASM_9_7

From this to me seems that this time there were no changes that could negatively impact us.

Godin · 2024-03-25T09:30:54Z


 <p>
-  <a href="https://asm.ow2.io/">ASM 9.6</a> is subject to the terms and
+  <a href="https://asm.ow2.io/">ASM 9.7</a> is subject to the terms and


I did check that their license stayed unchanged.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | patch | `2.0.3` -> `2.0.4` | | [commons-io:commons-io](https://commons.apache.org/proper/commons-io/) ([source](https://gitbox.apache.org/repos/asf?p=commons-io.git)) | compile | minor | `2.15.1` -> `2.16.1` | | [org.jacoco:jacoco-maven-plugin](https://www.jacoco.org/jacoco/trunk/doc/maven.html) ([source](https://github.com/jacoco/jacoco)) | build | patch | `0.8.11` -> `0.8.12` | | [com.google.guava:guava](https://github.com/google/guava) | compile | minor | `33.0.0-jre` -> `33.1.0-jre` | | [org.codehaus.janino:janino](http://janino-compiler.github.io/janino/) ([source](https://github.com/janino-compiler/janino)) | compile | patch | `3.1.11` -> `3.1.12` | | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.2.3` -> `3.2.5` | --- ### Release Notes <details> <summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary> ### [`v2.0.4`](spring-projects/spring-boot@v2.0.3.RELEASE...v2.0.4.RELEASE) [Compare Source](spring-projects/spring-boot@v2.0.3.RELEASE...v2.0.4.RELEASE) </details> <details> <summary>jacoco/jacoco (org.jacoco:jacoco-maven-plugin)</summary> ### [`v0.8.12`](https://github.com/jacoco/jacoco/releases/tag/v0.8.12): 0.8.12 [Compare Source](jacoco/jacoco@v0.8.11...v0.8.12) #### New Features - JaCoCo now officially supports Java 22 (GitHub [#1596](jacoco/jacoco#1596)). - Experimental support for Java 23 class files (GitHub [#1553](jacoco/jacoco#1553)). #### Fixed bugs - Branches added by the Kotlin compiler for functions with default arguments and having more than 32 parameters are filtered out during generation of report (GitHub [#1556](jacoco/jacoco#1556)). - Branch added by the Kotlin compiler version 1.5.0 and above for reading from lateinit property is filtered out during generation of report (GitHub [#1568](jacoco/jacoco#1568)). #### Non-functional Changes - JaCoCo now depends on ASM 9.7 (GitHub [#1600](jacoco/jacoco#1600)). </details> <details> <summary>janino-compiler/janino (org.codehaus.janino:janino)</summary> ### [`v3.1.12`](janino-compiler/janino@v3.1.11...v3.1.12) [Compare Source](janino-compiler/janino@v3.1.11...v3.1.12) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge...

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.assertj:assertj-core](https://assertj.github.io/doc/#assertj-core) ([source](https://github.com/assertj/assertj)) | test | minor | `3.24.2` -> `3.25.3` | | [org.jacoco:jacoco-maven-plugin](https://www.jacoco.org/jacoco/trunk/doc/maven.html) ([source](https://github.com/jacoco/jacoco)) | build | patch | `0.8.11` -> `0.8.12` | | [org.mockito:mockito-junit-jupiter](https://github.com/mockito/mockito) | test | minor | `5.7.0` -> `5.11.0` | | [org.slf4j:slf4j-api](http://www.slf4j.org) ([source](https://github.com/qos-ch/slf4j)) | compile | patch | `2.0.12` -> `2.0.13` | | [org.projectlombok:lombok](https://projectlombok.org) ([source](https://github.com/projectlombok/lombok)) | | patch | `1.18.30` -> `1.18.32` | | [org.projectlombok:lombok](https://projectlombok.org) ([source](https://github.com/projectlombok/lombok)) | compile | patch | `1.18.30` -> `1.18.32` | | [org.springframework.boot:spring-boot-dependencies](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.2.4` -> `3.2.5` | --- ### Release Notes <details> <summary>jacoco/jacoco (org.jacoco:jacoco-maven-plugin)</summary> ### [`v0.8.12`](https://github.com/jacoco/jacoco/releases/tag/v0.8.12): 0.8.12 [Compare Source](jacoco/jacoco@v0.8.11...v0.8.12) #### New Features - JaCoCo now officially supports Java 22 (GitHub [#1596](jacoco/jacoco#1596)). - Experimental support for Java 23 class files (GitHub [#1553](jacoco/jacoco#1553)). #### Fixed bugs - Branches added by the Kotlin compiler for functions with default arguments and having more than 32 parameters are filtered out during generation of report (GitHub [#1556](jacoco/jacoco#1556)). - Branch added by the Kotlin compiler version 1.5.0 and above for reading from lateinit property is filtered out during generation of report (GitHub [#1568](jacoco/jacoco#1568)). #### Non-functional Changes - JaCoCo now depends on ASM 9.7 (GitHub [#1600](jacoco/jacoco#1600)). </details> <details> <summary>mockito/mockito (org.mockito:mockito-junit-jupiter)</summary> ### [`v5.11.0`](https://github.com/mockito/mockito/releases/tag/v5.11.0) [Compare Source](mockito/mockito@v5.10.0...v5.11.0) <sup><sup>*Changelog generated by [Shipkit Changelog Gradle Plugin](https://github.com/shipkit/shipkit-changelog)*</sup></sup> ##### 5.11.0 - 2024-03-01 - [17 commit(s)](mockito/mockito@v5.10.0...v5.11.0) by Aouichaoui Youssef, Franz Wong, Pranoti Durugkar, Róbert Papp, dependabot\[bot] - Fixes [#3281](mockito/mockito#3281) : Add native method to exception message of MissingMethodI… [(#3283)](http...

marchof requested changes Mar 24, 2024

View reviewed changes

Comment thread org.jacoco.doc/docroot/doc/changes.html Outdated

Upgrade ASM to 9.7

5019324

Fixes jacoco#1599

merks force-pushed the issue-1599 branch from f03fe29 to 5019324 Compare March 24, 2024 19:15

Godin added the component: core label Mar 25, 2024

Godin added this to the 0.8.12 milestone Mar 25, 2024

Godin added 2 commits March 25, 2024 09:23

(WIP) mark as non-functional change

ade6374

(WIP) use link to PR

cbc201e

Godin self-assigned this Mar 25, 2024

marchof approved these changes Mar 25, 2024

View reviewed changes

Godin approved these changes Mar 25, 2024

View reviewed changes

Godin merged commit 40ff9fb into jacoco:master Mar 25, 2024

Godin mentioned this pull request Mar 25, 2024

Add configuration for Dependabot to simplify updates of ASM #1601

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade ASM to 9.7#1600

Upgrade ASM to 9.7#1600
Godin merged 3 commits intojacoco:masterfrom
merks:issue-1599

merks commented Mar 24, 2024

Uh oh!

merks commented Mar 24, 2024

Uh oh!

marchof left a comment

Uh oh!

Uh oh!

merks commented Mar 25, 2024

Uh oh!

merks commented Mar 25, 2024 •

edited

Loading

Uh oh!

Godin commented Mar 25, 2024

Uh oh!

Godin left a comment

Uh oh!

Godin Mar 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

merks commented Mar 24, 2024

Uh oh!

merks commented Mar 24, 2024

Uh oh!

marchof left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

merks commented Mar 25, 2024

Uh oh!

merks commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Godin commented Mar 25, 2024

Uh oh!

Godin left a comment

Choose a reason for hiding this comment

Uh oh!

Godin Mar 25, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

merks commented Mar 25, 2024 •

edited

Loading