Skip to content

fix: Remove esm interop#2225

Merged
UziTech merged 1 commit intomarkedjs:masterfrom
benmccann:esm-interop
Oct 6, 2021
Merged

fix: Remove esm interop#2225
UziTech merged 1 commit intomarkedjs:masterfrom
benmccann:esm-interop

Conversation

@benmccann
Copy link
Copy Markdown
Contributor

@benmccann benmccann commented Oct 6, 2021

Marked version: 3.0.5

Markdown flavor: all

Description

Alternative to #2224

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 6, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/7PPFvf6umYgKWUcnD6Js93uzFjae
✅ Preview: https://markedjs-git-fork-benmccann-esm-interop-markedjs.vercel.app

@benmccann benmccann mentioned this pull request Oct 6, 2021
Closed
@UziTech UziTech changed the title Remove esm interop fix: Remove esm interop Oct 6, 2021
@UziTech UziTech merged commit 4bc9121 into markedjs:master Oct 6, 2021
github-actions bot pushed a commit that referenced this pull request Oct 6, 2021
@semantic-release-bot
chore(release): 3.0.6 [skip ci]
3306813 
## [3.0.6](v3.0.5...v3.0.6) (2021-10-06)

### Bug Fixes

* Remove esm interop ([#2225](#2225)) ([4bc9121](4bc9121))
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 6, 2021

🎉 This PR is included in version 3.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@UziTech
Copy link
Copy Markdown
Member

UziTech commented Oct 6, 2021

This still seems to have not fixed it.

@benmccann
Copy link
Copy Markdown
Contributor Author

benmccann commented Oct 6, 2021

I will take a look now that I know what the issue is and see if I can come up with a better fix

@thexs-dev
Copy link
Copy Markdown

thexs-dev commented Oct 7, 2021

I was using this import line:
import * as marked from 'https://cdn.jsdelivr.net/npm/[email protected]/lib/marked.js';

And the web app broke with 3.0.6 release
I had to rollback to 3.0.4 to get it back

How should I import marked now from cdn.jsdelivr.net/npm/marked?

@UziTech
Copy link
Copy Markdown
Member

UziTech commented Oct 7, 2021

@thexs-dev v3.0.7 should work again

@thexs-dev
Copy link
Copy Markdown

thexs-dev commented Nov 19, 2021

This import line is working fine 3.0.7 as suggested above, but not for 4.0
import * as marked from 'https://cdn.jsdelivr.net/npm/[email protected]/lib/marked.js';

I know it's a trivial question, but I don't know the answer
How can I adapt that import line to load [email protected] ?
Thanks in advance

@styfle
Copy link
Copy Markdown
Member

styfle commented Nov 19, 2021

Try the ESM file

https://cdn.jsdelivr.net/npm/[email protected]/lib/marked.esm.js

Logiclayer1111 pushed a commit to Logiclayer1111/marked that referenced this pull request Apr 20, 2026
@semantic-release-bot
chore(release): 3.0.6 [skip ci]
9dc50d9 
## [3.0.6](markedjs/marked@v3.0.5...v3.0.6) (2021-10-06)

### Bug Fixes

* Remove esm interop ([#2225](markedjs/marked#2225)) ([368c37c](markedjs/marked@368c37c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UziTech UziTech UziTech approved these changes

@styfle styfle styfle approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

Assignees

No one assigned

Labels

hacktoberfest-accepted released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benmccann @UziTech @thexs-dev @styfle