Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/4GVhinkD5B8e9yGBnM2czZnEa748 |
624246e to
82ad1c6
Compare
|
We could probably remove |
ac583ce to
1435b2c
Compare
|
Ok, I've added
We could, but I actually think it might be preferable to keep as is so that we know the UMD and ESM versions have the same exposed APIs. I think it could be easier to document and explain that way. |
|
@UziTech I was wondering if you had any other thoughts about this? Is it something we could move forward with in the near future to avoid merge conflicts from accruing? |
|
Looks like vercel is failing because |
7ae77a6 to
de27d69
Compare
|
Ok, thanks for letting me know. I didn't have permission to see the Vercel link, so didn't know what was wrong. I've updated it so that it's working now |
|
I'll take a look at this soon and make sure all the ways of importing marked works or see where we would have to update our docs. |
|
Can you fix the |
|
I think that might have been from @UziTech 's changes. I'm not sure if perhaps that file is autogenerated from something, but I just manually updated it |
|
That is auto generated but we can edit it manually. Lines 12 to 13 in e93f800 |
df8e644 to
b1d8416
Compare
|
Cool. Do we need to wait for @davisjam, @joshbruce and @styfle to weigh in before merging? |
|
I was just giving a little bit of time for anyone to weigh in. I'll merge this later today if there is no issues. |
# [4.0.0](v3.0.8...v4.0.0) (2021-11-02) ### Bug Fixes * Convert to ESM ([#2227](#2227)) ([4afb228](4afb228)) ### BREAKING CHANGES * - Default export removed. Use `import { marked } from 'marked'` or `const { marked } = require('marked')` instead. - `/lib/marked.js` removed. Use `/marked.min.js` in script tag instead. - When using marked in a script tag use `marked.parse(...)` instead of `marked(...)`
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Ty 4 this! |
# [4.0.0](markedjs/marked@v3.0.8...v4.0.0) (2021-11-02) ### Bug Fixes * Convert to ESM ([#2227](markedjs/marked#2227)) ([0b0522e](markedjs/marked@0b0522e)) ### BREAKING CHANGES * - Default export removed. Use `import { marked } from 'marked'` or `const { marked } = require('marked')` instead. - `/lib/marked.js` removed. Use `/marked.min.js` in script tag instead. - When using marked in a script tag use `marked.parse(...)` instead of `marked(...)`
Marked version:
masterMarkdown flavor: all
Description
Converts the source code to ESM to be more modern and allow Rollup to better handle it. Rollup will still convert the final code to be UMD / ESM, but will do so more efficiently resulting in smaller output files
Contributor
Committer
In most cases, this should be a different person than the contributor.